Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 30 Nov 2017 10:57:35 -0500 (EST)
From:   Alan Stern <stern@rowland.harvard.edu>
To:     Mikhail Zaytsev <flashed@mail.ru>
cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-usb@vger.kernel.org>,
        <usb-storage@lists.one-eyed-alien.net>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] USB: storage: Remove obsolete "FIXME"
In-Reply-To: <20171130115407.35e5e8a2@zaitsev.tver.pg>
Message-ID: <Pine.LNX.4.44L0.1711301057260.1380-100000@iolanthe.rowland.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 30 Nov 2017, Mikhail Zaytsev wrote:

> The fix of "FIXME: Notify the subdrivers..." doesn't actually have any
>  real effect. The "FIXME" changed to simple comment. 
> 
> Signed-off-by: Mikhail Zaytsev <flashed@mail.ru>
> ---
>  drivers/usb/storage/usb.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
> index a0c07e0..3eb9347 100644
> --- a/drivers/usb/storage/usb.c
> +++ b/drivers/usb/storage/usb.c
> @@ -211,8 +211,8 @@ int usb_stor_reset_resume(struct usb_interface *iface)
>  	usb_stor_report_bus_reset(us);
>  
>  	/*
> -	 * FIXME: Notify the subdrivers that they need to reinitialize
> -	 * the device
> +	 * If any of the subdrivers implemented a reinitialization scheme,
> +	 * this is where the callback would be invoked.
>  	 */
>  	return 0;
>  }
> @@ -243,8 +243,8 @@ int usb_stor_post_reset(struct usb_interface *iface)
>  	usb_stor_report_bus_reset(us);
>  
>  	/*
> -	 * FIXME: Notify the subdrivers that they need to reinitialize
> -	 * the device
> +	 * If any of the subdrivers implemented a reinitialization scheme,
> +	 * this is where the callback would be invoked.
>  	 */
>  
>  	mutex_unlock(&us->dev_mutex);

Acked-by: Alan Stern <stern@rowland.harvard.edu>


From 1585480573902659874@xxx Thu Nov 30 08:55:02 +0000 2017
X-GM-THRID: 1585480573902659874
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread