Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 30 Nov 2017 10:38:32 -0800 (PST)
Subject:     Re: [patches] Re: [PATCH 08/10] RISC-V: Set __ARCH_WANT_RENAMEAT to pick up generic version
In-Reply-To: <20171130183032.GA28365@infradead.org>
CC:     Olof Johansson <olof@lixom.net>, albert@sifive.com,
        patches@groups.riscv.org, linux-kernel@vger.kernel.org,
        Arnd Bergmann <arnd@arndb.de>
From:   Palmer Dabbelt <palmer@sifive.com>
To:     Christoph Hellwig <hch@infradead.org>
Message-ID: <mhng-81e38176-6ac2-4c03-8dbe-b3194494a5b8@palmer-si-x1c4>
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 30 Nov 2017 10:30:32 PST (-0800), Christoph Hellwig wrote:
> On Wed, Nov 29, 2017 at 05:55:19PM -0800, Olof Johansson wrote:
>> In file included from ../lib/audit.c:8:0:
>> ../include/asm-generic/audit_dir_write.h:30:1: error: '__NR_renameat' undeclared here (not in a function); did you mean '__NR_renameat2'?
>
>
> I think the audit code should be fixed instead to not expect
> __NR_renameat, gіven that it's not in the asm-generic default set.

For some reason I thought we'd decided to keep renameat in our port despite it 
no longer being in the default list so we could maintain some backwards 
compatibility, but after looking through my email it looks like I was wrong 
about that.

I'm just going to drop this patch for now.  I haven't tried it, but I think 
this might just do the trick?

diff --git a/include/asm-generic/audit_dir_write.h b/include/asm-generic/audit_dir_write.h
index da09fb986459..dd5a9dd7a102 100644
--- a/include/asm-generic/audit_dir_write.h
+++ b/include/asm-generic/audit_dir_write.h
@@ -27,7 +27,9 @@ __NR_mknod,
 __NR_mkdirat,
 __NR_mknodat,
 __NR_unlinkat,
+#ifdef __NR_renameat
 __NR_renameat,
+#endif
 __NR_linkat,
 __NR_symlinkat,
 #endif

From 1585516895324966804@xxx Thu Nov 30 18:32:21 +0000 2017
X-GM-THRID: 1585454308346436918
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread