Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 29 Nov 2017 10:01:05 -0500
From:   "Gabriel L. Somlo" <somlo@cmu.edu>
To:     Vasyl Gomonovych <gomonovych@gmail.com>
Cc:     mst@redhat.com, qemu-devel@nongnu.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: Use PTR_ERR_OR_ZERO()
Message-ID: <20171129150105.GK5774@hedwig.ini.cmu.edu>
References: <1511905227-30292-1-git-send-email-gomonovych@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1511905227-30292-1-git-send-email-gomonovych@gmail.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Acked-by: Gabriel Somlo <somlo@cmu.edu>

On Tue, Nov 28, 2017 at 10:40:27PM +0100, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/firmware/efi/efi.c:610:8-14: WARNING: PTR_ERR_OR_ZERO can be used
> 
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> ---
>  drivers/firmware/qemu_fw_cfg.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
> index 5cfe39f7a45f..18489b6a696d 100644
> --- a/drivers/firmware/qemu_fw_cfg.c
> +++ b/drivers/firmware/qemu_fw_cfg.c
> @@ -693,10 +693,8 @@ static int fw_cfg_cmdline_set(const char *arg, const struct kernel_param *kp)
>  	 */
>  	fw_cfg_cmdline_dev = platform_device_register_simple("fw_cfg",
>  					PLATFORM_DEVID_NONE, res, processed);
> -	if (IS_ERR(fw_cfg_cmdline_dev))
> -		return PTR_ERR(fw_cfg_cmdline_dev);
>  
> -	return 0;
> +	return PTR_ERR_OR_ZERO(fw_cfg_cmdline_dev);
>  }
>  
>  static int fw_cfg_cmdline_get(char *buf, const struct kernel_param *kp)
> -- 
> 1.9.1
> 

From 1585347660432402973@xxx Tue Nov 28 21:42:26 +0000 2017
X-GM-THRID: 1585347660432402973
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread