Received: by 10.223.164.202 with SMTP id h10csp649092wrb; Thu, 30 Nov 2017 05:23:39 -0800 (PST) X-Google-Smtp-Source: AGs4zMYsycKCWnOF2GKXdDmsGSEJshgCWnM4JrAmRu0mV9I9XwqDl2T4t6SfXMetv/qMxu071PHY X-Received: by 10.84.139.1 with SMTP id 1mr2677658plq.20.1512048219062; Thu, 30 Nov 2017 05:23:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512048219; cv=none; d=google.com; s=arc-20160816; b=k/EEhKFzcaKnD7L0qZJ56mH6DHD44L3XB4q5x7M23meGk7jwu2F6PqHiPx6Wn1wvre z6bb5UlUoRKXtoF1haaIBRMMHv7MTloThzpUjuL9yD+1N6SriOXDUKxdkBImnpulCvss vKF7Fxo4yRLhNRf6CDp57vPWyt9deMmCC/nAj3YkrPAQLncLwaXcPICEBaZdB4w0VO+C la7n9MCR0TupC3AvloQs4BEE7xaUkcjFG8TBW78pi5GIDMD1V+aCGhxovsv0u4bb4XEy 6Md69EF1Esz72MLOmT6YJbNK2DnGbUqNBt5wUsJzmEEXsnvm+tVFhnQUkr+vcfoFBtSY YF+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=SKh8EndgT1/zx+sx/n08MvtZaVvohxvfuYOQglGPWSU=; b=imIlj+h3L+blm/knkKJCF+FW4xjXzhB1NubRvE/HbfUc+bOK7ET35NO+kGoZX3Rrn/ apFH7+WPcJDp7pjck+DsydjrbZt/R0liaCxSBJZwUnVm9c2UGV5DHDMOODvyK8qrhSM7 dkhigwjqbrv5+xOKpIdFDnvMpaYGBq3dxlIKOAjN9vQGmeTHwfNm/F1clKo90StOH+tB LFXb6Na0mBLcfvP5ekiuHMbpEu3+yIJSCE7iaNicen5AcO80X7VlE1sE+Vg0NgOsNyFl J+pjLL57COGptnLt+Nkx1QgrfETobwx1GiScuAlFIy+qzTMgCxDVXIZrq28Dx75zg2D+ reLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=P9QWHC9E; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l7si3176188pln.625.2017.11.30.05.23.25; Thu, 30 Nov 2017 05:23:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=P9QWHC9E; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753188AbdK3NVa (ORCPT + 99 others); Thu, 30 Nov 2017 08:21:30 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34704 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753018AbdK3NUn (ORCPT ); Thu, 30 Nov 2017 08:20:43 -0500 Received: by mail-wm0-f66.google.com with SMTP id y82so1563334wmg.1 for ; Thu, 30 Nov 2017 05:20:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SKh8EndgT1/zx+sx/n08MvtZaVvohxvfuYOQglGPWSU=; b=P9QWHC9EJlHC02HRUhXIFV+I+/QOKXmDNDSeQfUF5RW4IlhegYhQtUMThUnINcQRaL pMg1xJCDVl56m34hJh19Q4hc8oWnuYQoO7h8B/Hs3WYJm2DdRuwiAv9Nv8f+rY2acd0y 0y0LB4xMGdWjezKXGirL688D9Jzd/VGAtSHaxP9zyziFsOLOvExzFK15ur6+IjcROUq9 djeQ7lxUGGmFfFG+HVFbC5jMxksMMHyuz0hc2ZptOVQ/Z6Q51qbJChrQUUT9Pt0r5Nqc q7zI7HObzIONXEcsSfB+gUIwv6yrmNMttWwz1Cnma+8D57tfaHKvVYtxjg664+YT2V49 lyIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SKh8EndgT1/zx+sx/n08MvtZaVvohxvfuYOQglGPWSU=; b=O0IpSZXPlvYPJBOxxDnlIxehtgSvdJV0qGVpjCRnzDIOgx9CtDllz3A2qK7DNJaBqQ ZalizhW/WZ2dCcV4TAqNpfuWjmTcc+dGLJH2R8Jo9+a7QKtPWHFcUO406qOdcaZ5w+Iy 5o1Ic2Vj7Wy1Tgyh3QnGqSXchKbT+OV/de2hNeW7AqTFoLK2qZKglR/a3bkKm2+zs5yQ faN4nW6/qV1e2wrGF32w8vBeUDo/qD02fOZ5ZtcH61cDzJ9WVGKmoCqWQ32JRjlip4vN 7Vh5Y2Af8mtlaCIZQZ36bHsj2/+T1aNc/owxBqGLaLkNRptlk8mUkogR7X85uPcu/Lzu YXbw== X-Gm-Message-State: AJaThX7DYL0h23H6zjnld4x743yL/4OKJ0kL0dUYS8xcWpKSVfh5io1H JvX3R93036gv6re9E+/lRuamdA== X-Received: by 10.28.47.68 with SMTP id v65mr544753wmv.11.1512048041744; Thu, 30 Nov 2017 05:20:41 -0800 (PST) Received: from localhost.localdomain ([87.121.44.226]) by smtp.gmail.com with ESMTPSA id p200sm3539734wmd.9.2017.11.30.05.20.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Nov 2017 05:20:41 -0800 (PST) From: "Vladislav Valtchev (VMware)" To: rostedt@goodmis.org Cc: linux-kernel@vger.kernel.org, y.karadz@gmail.com, "Vladislav Valtchev (VMware)" Subject: [PATCH v2 07/10] trace-cmd: Mov init_common_record_context in parse_record_options Date: Thu, 30 Nov 2017 15:19:54 +0200 Message-Id: <20171130131957.21617-8-vladislav.valtchev@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20171130131957.21617-1-vladislav.valtchev@gmail.com> References: <20171130131957.21617-1-vladislav.valtchev@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This short patch moves init_common_record_context() into parse_record_option() after checking that no trace_* function in trace-record.c really needs to do work after init_common_record_context() but before parse_record_option(). In particular, two statements in trace_profile() have been moved after the call of parse_record_option(), since they did not actually affect it. Signed-off-by: Vladislav Valtchev (VMware) --- trace-record.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/trace-record.c b/trace-record.c index 55e81cf..7688565 100644 --- a/trace-record.c +++ b/trace-record.c @@ -4405,6 +4405,7 @@ static void init_common_record_context(struct common_record_context *ctx, static void parse_record_options(int argc, char **argv, + enum trace_cmd curr_cmd, struct common_record_context *ctx) { const char *plugin = NULL; @@ -4416,6 +4417,8 @@ static void parse_record_options(int argc, char *sav; int neg_event = 0; + init_common_record_context(ctx, curr_cmd); + for (;;) { int option_index = 0; int ret; @@ -4925,8 +4928,7 @@ void trace_start(int argc, char **argv) { struct common_record_context ctx; - init_common_record_context(&ctx, CMD_start); - parse_record_options(argc, argv, &ctx); + parse_record_options(argc, argv, CMD_start, &ctx); record_trace(argc, argv, &ctx); exit(0); } @@ -4935,8 +4937,7 @@ void trace_extract(int argc, char **argv) { struct common_record_context ctx; - init_common_record_context(&ctx, CMD_extract); - parse_record_options(argc, argv, &ctx); + parse_record_options(argc, argv, CMD_extract, &ctx); record_trace(argc, argv, &ctx); exit(0); } @@ -4945,8 +4946,7 @@ void trace_stream(int argc, char **argv) { struct common_record_context ctx; - init_common_record_context(&ctx, CMD_stream); - parse_record_options(argc, argv, &ctx); + parse_record_options(argc, argv, CMD_stream, &ctx); record_trace(argc, argv, &ctx); exit(0); } @@ -4955,13 +4955,11 @@ void trace_profile(int argc, char **argv) { struct common_record_context ctx; - init_common_record_context(&ctx, CMD_profile); + parse_record_options(argc, argv, CMD_profile, &ctx); handle_init = trace_init_profile; ctx.events = 1; - parse_record_options(argc, argv, &ctx); - /* * If no instances were set, then enable profiling on the top instance. */ @@ -4977,8 +4975,7 @@ void trace_record(int argc, char **argv) { struct common_record_context ctx; - init_common_record_context(&ctx, CMD_record); - parse_record_options(argc, argv, &ctx); + parse_record_options(argc, argv, CMD_record, &ctx); record_trace(argc, argv, &ctx); exit(0); } -- 2.14.1 From 1585548351389879780@xxx Fri Dec 01 02:52:20 +0000 2017 X-GM-THRID: 1585548351389879780 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread