Received: by 10.223.164.202 with SMTP id h10csp1204075wrb; Sun, 26 Nov 2017 22:24:35 -0800 (PST) X-Google-Smtp-Source: AGs4zMaxi8aiKVoMDQatGGBzxddORGGx4/emWymycKehRu/9k6txC+xKWM+yh8nIglazriSiTH5E X-Received: by 10.99.113.83 with SMTP id b19mr35183457pgn.41.1511763875885; Sun, 26 Nov 2017 22:24:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511763875; cv=none; d=google.com; s=arc-20160816; b=CVtQyP16PscXwelE0a1s/ROplokhkWFvUhJ3Sf7Xl/ICIBh63TrTe4SzyuXCYybCtx 6IcOrX4W5pRcmnVv5vKNT4IbrQRv1EFy8PdzctHPVWv16h1+POodQRfUXI8ZYX10WMTt AjA48JBCRNRbAW/BIa2x1dEA+uA5xZ/72t2FUjU1rq2+WgjIWiitlPpmtWQcDj23wO73 dfSWVVK1S93nOhgu9Kqcx2c9Eh/2hDxbsYeUadwNHV1KktmyuJ7Od2IwNHSN4rcBWjqb ZcSHcXgSCYgXWv7/YS7GwmLBt/zSXpSMo3E1yGGrla21HJXejMa8xrcMN3SGATE5ULlI x4OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:from:cc:references:to :subject:arc-authentication-results; bh=doFc5H8UslM0yn1V5TuHEZrBR76vRYv5hhYRlXOALAI=; b=YwuL2mJQrjQxJldebqKJF/sxGJHg0ilWyH6cniat/aa1nOK9V/HTHIBZb9DjSH0xYc rhWtGSSxXRMPhJA8YgtmmRMy4/PyScICEn1W1zi2HfbgkcF5Hc6JD2gBm2c3zH7UB28L fiMnVmuJTClRLgqZ0svMuTnbyZD1uZz0WB+uh+Ajxk5RbhNmISN5Zvouonli0syKXd8T uOcJgX6qKvzSjZZVhZav0OrvQAI7LBjAiAnijb3aEEkHqlH53xgGh4KwTX5bq0dRzCyA V5l4ItvFajj9dUJU+QC8UINUOm3CZCr3OXZZwLPbMej0Jdyamz9s06Ma1t6yulkjyOis vYyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k22si17097624pll.12.2017.11.26.22.24.24; Sun, 26 Nov 2017 22:24:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751702AbdK0GW2 (ORCPT + 78 others); Mon, 27 Nov 2017 01:22:28 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:45540 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270AbdK0GW0 (ORCPT ); Mon, 27 Nov 2017 01:22:26 -0500 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vAR6JXKR098080 for ; Mon, 27 Nov 2017 01:22:26 -0500 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 2eg9m50d5h-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 27 Nov 2017 01:22:26 -0500 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 27 Nov 2017 06:22:23 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 27 Nov 2017 06:22:19 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id vAR6MIlo43450516; Mon, 27 Nov 2017 06:22:18 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9128611C102; Mon, 27 Nov 2017 06:16:54 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2F86211C101; Mon, 27 Nov 2017 06:16:52 +0000 (GMT) Received: from [9.202.14.239] (unknown [9.202.14.239]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 27 Nov 2017 06:16:51 +0000 (GMT) Subject: Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages To: JianKang Chen , akpm@linux-foundation.org, mhocko@suse.com, mgorman@techsingularity.net, hillf.zj@alibaba-inc.com References: <1511594447-3836-1-git-send-email-chenjiankang1@huawei.com> Cc: hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, xieyisheng1@huawei.com, guohanjun@huawei.com, wangkefeng.wang@huawei.com From: Anshuman Khandual Date: Mon, 27 Nov 2017 11:52:15 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1511594447-3836-1-git-send-email-chenjiankang1@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17112706-0012-0000-0000-00000591D2F6 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17112706-0013-0000-0000-0000190CB382 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-27_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1711270088 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/25/2017 12:50 PM, JianKang Chen wrote: > From: Jiankang Chen > > __get_free_pages will return an 64bit address in 64bit System > like arm64 or x86_64. And this comment really confuse new bigenner of > mm. Normally its not 64 bit virtual address though CPU architecture supports 64 bits. But yes, specifying it as general virtual address without number of bits is better. From 1585022330389114456@xxx Sat Nov 25 07:31:27 +0000 2017 X-GM-THRID: 1585019167239466893 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread