Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 30 Nov 2017 10:26:36 -0800 (PST)
Subject:     Re: [patches] [PATCH 06/10] RISC-V: Provide stub of setup_profiling_timer()
In-Reply-To: <20171130015521.1289-7-olof@lixom.net>
CC:     albert@sifive.com, patches@groups.riscv.org,
        linux-kernel@vger.kernel.org, Olof Johansson <olof@lixom.net>
From:   Palmer Dabbelt <palmer@sifive.com>
To:     Olof Johansson <olof@lixom.net>
Message-ID: <mhng-4776ddc9-3d51-4c96-ba41-11c8ebbc0b2f@palmer-si-x1c4>
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 29 Nov 2017 17:55:17 PST (-0800), Olof Johansson wrote:
> Fixes the following on allmodconfig build:
>
> profile.c:(.text+0x3e4): undefined reference to `setup_profiling_timer'
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
>  arch/riscv/kernel/smp.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.c
> index b4a71ec..4498f0c 100644
> --- a/arch/riscv/kernel/smp.c
> +++ b/arch/riscv/kernel/smp.c
> @@ -38,6 +38,13 @@ enum ipi_message_type {
>  	IPI_MAX
>  };
>
> +
> +/* Unsupported */
> +int setup_profiling_timer(unsigned int multiplier)
> +{
> +	return -EINVAL;
> +}
> +
>  irqreturn_t handle_ipi(void)
>  {
>  	unsigned long *pending_ipis = &ipi_data[smp_processor_id()].bits;
> @@ -108,3 +115,4 @@ void smp_send_reschedule(int cpu)
>  {
>  	send_ipi_message(cpumask_of(cpu), IPI_RESCHEDULE);
>  }
> +

This adds a trailing newline, I'm going to drop it in my tree

commit 5c0a7217f172899ddacc32bac16549a274a5ae05
Author: Olof Johansson <olof@lixom.net>
Date:   Wed Nov 29 17:55:20 2017 -0800

    RISC-V: Add missing include

    Fixes:

    include/asm-generic/mm_hooks.h:20:11: warning: 'struct vm_area_struct' declared inside parameter list will not be visible outside of this definition or declaration
    include/asm-generic/mm_hooks.h:19:38: warning: 'struct mm_struct' declared inside parameter list will not be visible outside of this definition or declaration

    Signed-off-by: Olof Johansson <olof@lixom.net>
    Signed-off-by: Palmer Dabbelt <palmer@sifive.com>

diff --git a/arch/riscv/include/asm/mmu_context.h b/arch/riscv/include/asm/mmu_context.h
index de1fc1631fc4..1cd5172882c2 100644
--- a/arch/riscv/include/asm/mmu_context.h
+++ b/arch/riscv/include/asm/mmu_context.h
@@ -14,6 +14,7 @@
 #ifndef _ASM_RISCV_MMU_CONTEXT_H
 #define _ASM_RISCV_MMU_CONTEXT_H

+#include <linux/mm_types.h>
 #include <asm-generic/mm_hooks.h>

 #include <linux/mm.h>


From 1585454401841502441@xxx Thu Nov 30 01:59:02 +0000 2017
X-GM-THRID: 1585454401841502441
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread