Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <fd5bc34b-2bd2-13e2-b7e0-cf14e1c899f4@linux.intel.com>
References: <20171127104923.14378-1-mingo@kernel.org> <20171127104923.14378-16-mingo@kernel.org>
 <20171130154414.aekkjd26p3hxyqwa@hirez.programming.kicks-ass.net>
 <3ca0bea7-932a-6d91-a9b4-d07045d444f5@linux.intel.com> <20171130161844.v7ynfdggo6g7j5l5@hirez.programming.kicks-ass.net>
 <fd5bc34b-2bd2-13e2-b7e0-cf14e1c899f4@linux.intel.com>
From:   Andy Lutomirski <luto@amacapital.net>
Date:   Thu, 30 Nov 2017 10:48:56 -0800
Message-ID: <CALCETrUhFKesaQrC07eMaCQHhvHaCcB9KtxeqMvN3cSfRXxRBg@mail.gmail.com>
Subject: Re: [PATCH 15/24] x86/mm: Allow flushing for future ASID switches
To:     Dave Hansen <dave.hansen@linux.intel.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "H . Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
        Linus Torvalds <torvalds@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 30, 2017 at 10:44 AM, Dave Hansen
<dave.hansen@linux.intel.com> wrote:
> On 11/30/2017 08:18 AM, Peter Zijlstra wrote:
>> On Thu, Nov 30, 2017 at 07:51:17AM -0800, Dave Hansen wrote:
>>> On 11/30/2017 07:44 AM, Peter Zijlstra wrote:
>>>> On Mon, Nov 27, 2017 at 11:49:14AM +0100, Ingo Molnar wrote:
>>>>> @@ -338,24 +366,23 @@ static inline void __native_flush_tlb_single(unsigned long addr)
>>>>>
>>>>>  static inline void __flush_tlb_all(void)
>>>>>  {
>>>>> +  if (boot_cpu_has(X86_FEATURE_PGE)) {
>>>>>            __flush_tlb_global();
>>>>> +  } else {
>>>>>            __flush_tlb();
>>>>> +          tlb_flush_shared_nonglobals();
>>>> I do however think this one is superfluous; if we do not have PGE we
>>>> also do not have PCID and every CR3 switch flushes everything.
>>>
>>> I tried to sprinkle these around at all the sites that did non-global
>>> kernel flushes.  In the case that it's superfluous !KAISER, it's a noop
>>> anyway.  In the (currently unsupported) case that we *do* need it, well,
>>> we need it.
>>
>> I'm confused. When would we need it there?
>
> __flush_tlb() does a flushing CR3 write that flushes the current PCID.
> If we need other PCIDs flushed, we have to do it via the
> tlb_flush_shared_nonglobals() mechanism.
>
> Does it matter today in practice?  Nope, we never have that situation.
> But, it also doesn't _hurt_ to have that line there in any way.

Should it be tlb_flush_shared_nonglobals_if_kernel_and_user_pagetables_are_separate()?

The whole idea that we can get away with ambiguous functions like
__flush_tlb() seems to be much less true with KAISER.  I think we
should maybe start getting rid of overly vague functions like this.

From 1585517813842071600@xxx Thu Nov 30 18:46:57 +0000 2017
X-GM-THRID: 1585216393710549190
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread