Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4
To:     Trond Myklebust <trondmy@primarydata.com>,
        "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>
References: <20171129215853.20172851@vmware.local.home>
 <CA+55aFwtc+_ohqvFXZC6rqWbOEL1SbLF-oR=v+x+2Y2oVr+cuQ@mail.gmail.com>
 <20171129193927.e4248d8a797b90aa03edd0ff@linux-foundation.org>
 <CA+55aFxDuQN4EBxNtv+T3c6o0SDCtqEZavXPbuRzYMANb61Wug@mail.gmail.com>
 <20171129230528.6955b58a@vmware.local.home>
 <1512042402.34281.1.camel@primarydata.com>
From:   Anna Schumaker <Anna.Schumaker@Netapp.com>
Message-ID: <33264809-a49c-7c91-842f-153dd0eaf66c@Netapp.com>
Date:   Thu, 30 Nov 2017 08:05:39 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1512042402.34281.1.camel@primarydata.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Received-SPF: None (protection.outlook.com: netapp.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2017 13:05:43.0449 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 97451032-20c1-4344-2e1c-08d537f310b0
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4b0911a0-929b-4715-944b-c03745165b3a
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR06MB2475
X-OriginatorOrg: netapp.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/30/2017 06:46 AM, Trond Myklebust wrote:
> On Wed, 2017-11-29 at 23:05 -0500, Steven Rostedt wrote:
>> On Wed, 29 Nov 2017 19:44:33 -0800
>> Linus Torvalds <torvalds@linux-foundation.org> wrote:
>>
>> I keep older compilers around to test ftrace before -mfentry was
>> introduced.
>>
>> I wonder if I should just add a config to force the use without
>> -mfentry even if the compiler supports it.
>>
>>>  fs/nfs/nfs4state.c   | 3 +--
>>>  include/linux/nfs4.h | 2 +-
>>>  2 files changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
>>> index 54fd56d715a8..9db5d0d57fcb 100644
>>> --- a/fs/nfs/nfs4state.c
>>> +++ b/fs/nfs/nfs4state.c
>>> @@ -71,8 +71,7 @@ const nfs4_stateid zero_stateid = {
>>>  };
>>>  const nfs4_stateid invalid_stateid = {
>>>  	{
>>> -		.seqid = cpu_to_be32(0xffffffffU),
>>> -		.other = { 0 },
>>> +		{ .seqid = cpu_to_be32(0xffffffffU), .other = { 0
>>> }, },
>>
>> I tried this and it failed.
>>
>>>  	},
>>>  	.type = NFS4_INVALID_STATEID_TYPE,
>>>  };
>>> diff --git a/include/linux/nfs4.h b/include/linux/nfs4.h
>>> index 47adac640191..e394ba0cd6c5 100644
>>> --- a/include/linux/nfs4.h
>>> +++ b/include/linux/nfs4.h
>>> @@ -53,11 +53,11 @@ typedef struct { char data[NFS4_VERIFIER_SIZE];
>>> } nfs4_verifier;
>>>  
>>>  struct nfs4_stateid_struct {
>>>  	union {
>>> -		char data[NFS4_STATEID_SIZE];
>>>  		struct {
>>>  			__be32 seqid;
>>>  			char other[NFS4_STATEID_OTHER_SIZE];
>>>  		} __attribute__ ((packed));
>>> +		char data[NFS4_STATEID_SIZE];
>>
>> But I didn't try this. This looks to be the key.
>>
>> This works for me.
>>
>> Tested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>>
>> -- Steve
>>
>>>  	};
>>>  
>>>  	enum {
>>
>>
> 
> We already have a fix queued up for this issue. It was reported and the
> patch hit linux-nfs+linux-kernel almost 2 weeks ago. Anna?

I have it queued up, and I was planning to send it this week with some other fixes.

Anna
> 

From 1585494064368713240@xxx Thu Nov 30 12:29:28 +0000 2017
X-GM-THRID: 1585458198994635532
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread