Received: by 10.223.164.202 with SMTP id h10csp647845wrb; Thu, 30 Nov 2017 05:22:31 -0800 (PST) X-Google-Smtp-Source: AGs4zMZ/3iqs0+ogRGWkj3nZ5HlKxJnlxtox0n+7FFelM+gJV5VUHAVgnufGehwq403MdtpyHGkX X-Received: by 10.99.3.146 with SMTP id 140mr2299728pgd.273.1512048150906; Thu, 30 Nov 2017 05:22:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512048150; cv=none; d=google.com; s=arc-20160816; b=UxVJvllnxQ6PoCEzLUmltHYjphOIWdnxl+f8jITTdmQsYqk+jVpyqtIikRw23kZvso cS3UV0bQ1wGo+3CFOJ3+60i6ttPgYvJfI3iQFAtsZ3MAfmM/JBG3TIaJUmX1OYbZCYO9 6MB0fY2l+ej0tMlXfKlJq3btQQQGteQQGEpKx7k98QhyUVr/0rLNE/BA7+q4OAjcoSlZ wA8bLnBlVIlvgvyi0bXe7NEModtU+72h8PYGQDwxRu0aqd+vjpFPpFc8B7XJ5/ftPiQ+ RFGdSM7q03sQajV4CzEdxWJSnesDJI+fUmMXrN3Myma5QIyIrJOJJKO0P3lUhY8xiOwy t0qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=3QpeQd/2wF8S5fesyE1n+OlBE1JLVFVvYF1z8Ln0z/8=; b=AKmkBy3j6JCMGS32br0nXjT5lA3onBRGV3wpQgy0InU0YTmrCvpxVPhUJXwJbnteO9 cqu+wlgv3r9v/pFTiOdeTMCA9QQuk7quvmKJWxyr/zG+zHyK9L0x1Fh5OAuaAYwNI2d/ MxXelDcfh4/PG591a1COB2VN044KApb1cIL8h4RoCl/6Ezuc9RS7yYhEziadEqCfRcD1 ceMAjE/nzGXa7ew9c1QBrbtWyFsdbizRjy+QBrXSlsaZH1mTH7A3jtwZAnZ5j3i8D2Ee 2QZaXbHUqjgFKVMkUAvsOWCYkb5kPpbA3JUZTPmXBqu4oUMeGJ1qTEUDpUH1Xwk2yfky KynQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=aAdT6hXn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c21si3090158pls.397.2017.11.30.05.22.17; Thu, 30 Nov 2017 05:22:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=aAdT6hXn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753100AbdK3NUr (ORCPT + 99 others); Thu, 30 Nov 2017 08:20:47 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:46893 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753054AbdK3NUp (ORCPT ); Thu, 30 Nov 2017 08:20:45 -0500 Received: by mail-wm0-f65.google.com with SMTP id r78so13020981wme.5 for ; Thu, 30 Nov 2017 05:20:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3QpeQd/2wF8S5fesyE1n+OlBE1JLVFVvYF1z8Ln0z/8=; b=aAdT6hXnIjOlX9QE78scd0AAaNsds1PZzPvav01WmQzV/8ofMZNoBCxu8bynPkZt4K iwIXNLTuGyrjd+/GghAjmyRU0x7+44mR8AuX2ZJCYdIv/JN6WHeTe8Q/14UInMMOFePK DAWuTc7JVOg42SNld4PLAO751aEnXFJhxpesqkmpFGS461UOpJHVyuXWzAwhn3k3WIj+ ZN33EqwLxCOD8KxXZsdciyPwny1C8zT3dECb9RRzR/zM1OJeMfjswnw88zY6zWIF6dA6 7ujsggPtqzKws9cMtoI1yQZVrJKOB9RHDjg27vHm4ZxKWL0cLfZU56r/WxfEQPXCY06H n/QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3QpeQd/2wF8S5fesyE1n+OlBE1JLVFVvYF1z8Ln0z/8=; b=uVjZeTjclOF33Nn7HbAGynzBRHoSQuVjKW0B8vAD8mXIx1VtgfEuH/eUEYyc4GbUUy 5jWLS2V3KU+Y15ZHFHuepWMUPPjzZmGo3ue37U1VP4UytY4qMYlQO6K7ilvt8Ca4s7cr 4qQ2u+AlDHCx8CYz7efjhCGr9MLv3FAUL+dE56f6Z/VlDiI7Lx0dqGtEGLQ6yBxgdes0 5MO1x5ptoNxEdSEcNapulkEOJLwTr7xtEKjNagwdx+40nemauIiwJNGigCFfq96D7sYN HOCYlqjbdLXELQ0SAMQRJ/3jMoonfqSOQX/6BPTE7UVr9/faSQI5X+lJOtAWG8V1Z3Y0 T8hw== X-Gm-Message-State: AJaThX6uuzbykETHIxvHdvwXzXSL+4UrDYheR+e8fBag7w8fDevW6PC4 ++KMV1npkMYyQ5A7Alup1Tj94A== X-Received: by 10.28.222.132 with SMTP id v126mr1794009wmg.127.1512048043899; Thu, 30 Nov 2017 05:20:43 -0800 (PST) Received: from localhost.localdomain ([87.121.44.226]) by smtp.gmail.com with ESMTPSA id p200sm3539734wmd.9.2017.11.30.05.20.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Nov 2017 05:20:43 -0800 (PST) From: "Vladislav Valtchev (VMware)" To: rostedt@goodmis.org Cc: linux-kernel@vger.kernel.org, y.karadz@gmail.com, "Vladislav Valtchev (VMware)" Subject: [PATCH v2 09/10] trace-cmd: Extract finalize_record_trace() Date: Thu, 30 Nov 2017 15:19:56 +0200 Message-Id: <20171130131957.21617-10-vladislav.valtchev@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20171130131957.21617-1-vladislav.valtchev@gmail.com> References: <20171130131957.21617-1-vladislav.valtchev@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch splits record_trace() in two parts by moving its finalization part in a separate function. This will also allow splitting out trace-cmd extract code from trace-cmd record code, by using a shared function. Signed-off-by: Vladislav Valtchev (VMware) --- trace-record.c | 48 ++++++++++++++++++++++++++---------------------- 1 file changed, 26 insertions(+), 22 deletions(-) diff --git a/trace-record.c b/trace-record.c index ec0eaed..749c205 100644 --- a/trace-record.c +++ b/trace-record.c @@ -4767,6 +4767,31 @@ static enum trace_type get_trace_cmd_type(enum trace_cmd cmd) die("Trace type UNKNOWN for the given cmd_fun"); } +static void finalize_record_trace(struct common_record_context *ctx) +{ + if (keep) + return; + + update_reset_files(); + update_reset_triggers(); + if (clear_function_filters) + clear_func_filters(); + + set_plugin("nop"); + + tracecmd_remove_instances(); + + /* If tracing_on was enabled before we started, set it on now */ + for_all_instances(ctx->instance) { + if (ctx->instance->keep) + write_tracing_on(ctx->instance, + ctx->instance->tracing_on_init_val); + } + + if (host) + tracecmd_output_close(network_handle); +} + /* * This function contains common code for the following commands: * record, start, extract, stream, profile. @@ -4910,28 +4935,7 @@ static void record_trace(int argc, char **argv, print_stats(); destroy_stats(); - - if (keep) - return; - - update_reset_files(); - update_reset_triggers(); - if (clear_function_filters) - clear_func_filters(); - - set_plugin("nop"); - - tracecmd_remove_instances(); - - /* If tracing_on was enabled before we started, set it on now */ - for_all_instances(ctx->instance) { - if (ctx->instance->keep) - write_tracing_on(ctx->instance, - ctx->instance->tracing_on_init_val); - } - - if (host) - tracecmd_output_close(network_handle); + finalize_record_trace(ctx); } void trace_start(int argc, char **argv) -- 2.14.1 From 1586124682115320704@xxx Thu Dec 07 11:32:51 +0000 2017 X-GM-THRID: 1586124682115320704 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread