Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <78c06786-8bfc-3f15-fdb5-061691010509@mentor.com>
References: <9bd0bfdaf4e869e6216a0ef032b52cd28b33ab16.1512032962.git.baolin.wang@linaro.org>
 <78c06786-8bfc-3f15-fdb5-061691010509@mentor.com>
From:   Baolin Wang <baolin.wang@linaro.org>
Date:   Thu, 30 Nov 2017 18:45:35 +0800
Message-ID: <CAMz4kuKxazQBhSFhzeJ4awO4T1uA9Mm5oWUdzseTMOh8NpQqxQ@mail.gmail.com>
Subject: Re: [PATCH v5] mfd: syscon: Add hardware spinlock support
To:     Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc:     Lee Jones <lee.jones@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Mark Brown <broonie@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        DTML <devicetree@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 30 November 2017 at 18:38, Vladimir Zapolskiy
<vladimir_zapolskiy@mentor.com> wrote:
> On 11/30/2017 11:10 AM, Baolin Wang wrote:
>> Some system control registers need hardware spinlock to synchronize
>> between the multiple subsystems, so we should add hardware spinlock
>> support for syscon.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
>> Acked-by: Rob Herring <robh@kernel.org>
>> ---
>> Changes since v4:
>>  - Add one exapmle to show how to add hwlock.
>>  - Fix the coding style issue.
>>
>> Changes since v3:
>>  - Add error handling for of_hwspin_lock_get_id()
>>
>> Changes since v2:
>>  - Add acked tag from Rob.
>>
>> Changes since v1:
>>  - Remove timeout configuration.
>>  - Modify the binding file to add hwlocks.
>> ---
>>  Documentation/devicetree/bindings/mfd/syscon.txt |    8 ++++++++
>>  drivers/mfd/syscon.c                             |   21 +++++++++++++++++++++
>>  2 files changed, 29 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.txt b/Documentation/devicetree/bindings/mfd/syscon.txt
>> index 8b92d45..25d9e9c 100644
>> --- a/Documentation/devicetree/bindings/mfd/syscon.txt
>> +++ b/Documentation/devicetree/bindings/mfd/syscon.txt
>> @@ -16,9 +16,17 @@ Required properties:
>>  Optional property:
>>  - reg-io-width: the size (in bytes) of the IO accesses that should be
>>    performed on the device.
>> +- hwlocks: reference to a phandle of a hardware spinlock provider node.
>>
>>  Examples:
>>  gpr: iomuxc-gpr@20e0000 {
>>       compatible = "fsl,imx6q-iomuxc-gpr", "syscon";
>>       reg = <0x020e0000 0x38>;
>> +     hwlocks = <&hwlock1 1>;
>> +};
>> +
>> +hwlock1: hwspinlock@40500000 {
>> +     ...
>> +     reg = <0x40500000 0x1000>;
>> +     #hwlock-cells = <1>;
>>  };
>> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
>> index b93fe4c..5b67dbc 100644
>> --- a/drivers/mfd/syscon.c
>> +++ b/drivers/mfd/syscon.c
>> @@ -13,6 +13,7 @@
>>   */
>>
>>  #include <linux/err.h>
>> +#include <linux/hwspinlock.h>
>>  #include <linux/io.h>
>>  #include <linux/module.h>
>>  #include <linux/list.h>
>> @@ -87,6 +88,26 @@ static struct syscon *of_syscon_register(struct device_node *np)
>>       if (ret)
>>               reg_io_width = 4;
>>
>> +     ret = of_hwspin_lock_get_id(np, 0);
>> +     if (ret > 0) {
>> +             syscon_config.hwlock_id = ret;
>> +             syscon_config.hwlock_mode = HWLOCK_IRQSTATE;
>> +     } else {
>> +             switch (ret) {
>> +             case -ENOENT:
>> +                     /* Ignore missing hwlock, it's optional. */
>> +                     break;
>> +             case 0:
>> +                     ret = -EINVAL;
>> +                     /* fall-through */
>
> It breaks the execution on all kernels without CONFIG_HWSPINLOCK enabled.

Ah, your are correct. Sorry, I missed this case. I will fix this in
next version. Thanks.

-- 
Baolin.wang
Best Regards

From 1585487109508960756@xxx Thu Nov 30 10:38:55 +0000 2017
X-GM-THRID: 1584567099391769753
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread