Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20171129155528.16910-3-hdegoede@redhat.com>
References: <20171129155528.16910-1-hdegoede@redhat.com> <20171129155528.16910-3-hdegoede@redhat.com>
From:   Philippe Ombredanne <pombredanne@nexb.com>
Date:   Wed, 29 Nov 2017 18:10:05 +0100
Message-ID: <CAOFm3uG40py1mK1QDk0NoN3PWLe8cqgSARkh6GDi974T791NMQ@mail.gmail.com>
Subject: Re: [PATCH v3 3/3] virt: Add vboxguest driver for Virtual Box Guest integration
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Thayer <michael.thayer@oracle.com>,
        "Knut St . Osmundsen" <knut.osmundsen@oracle.com>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Christoph Hellwig <hch@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 29, 2017 at 4:55 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> diff --git a/drivers/virt/vboxguest/vboxguest_core.c b/drivers/virt/vboxguest/vboxguest_core.c
> new file mode 100644
> index 000000000000..631101578c2a
> --- /dev/null
> +++ b/drivers/virt/vboxguest/vboxguest_core.c
> @@ -0,0 +1,1582 @@
> +/*
> + * vboxguest core guest-device handling code, VBoxGuest.cpp in upstream svn.
> + *
> + * Copyright (C) 2007-2016 Oracle Corporation
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * The contents of this file may alternatively be used under the terms
> + * of the Common Development and Distribution License Version 1.0
> + * (CDDL) only, in which case the provisions of the CDDL are applicable
> + * instead of those of the GPL.
> + *
> + * You may elect to license modified versions of this file under the
> + * terms and conditions of either the GPL or the CDDL or both.
> + */

Hans:
Could it make sense to replace this whole license boilerplate with the
new SPDX license ids? e.g. use this instead:

> +// SPDX-License-Identifier: (GPL-2.0 OR CDDL-1.0)
> +/*
> + * vboxguest core guest-device handling code, VBoxGuest.cpp in upstream svn.
> + *
> + * Copyright (C) 2007-2016 Oracle Corporation

This would me much more compact and has the same effect. IMHO this
especially makes sense for new code as we are still cleaning the rest
of the kernel, so this would avoid extra work to clean this up later.

-- 
Cordially
Philippe Ombredanne

From 1585416524306580734@xxx Wed Nov 29 15:57:00 +0000 2017
X-GM-THRID: 1585142010203838290
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread