Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH] x86/entry/64: Fix native_load_gs_index() SWAPGS handling with IRQ state tracing enabled
From:   Andy Lutomirski <luto@amacapital.net>
In-Reply-To: <20171129124711.slmq5emx4f26c4zp@hirez.programming.kicks-ass.net>
Date:   Wed, 29 Nov 2017 06:33:37 -0800
Cc:     Ingo Molnar <mingo@kernel.org>,
        Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Borislav Petkov <bp@alien8.de>
Content-Transfer-Encoding: quoted-printable
Message-Id: <D6A6B532-57B5-4393-A322-DD441BEE74C4@amacapital.net>
References: <0fede9f9-88b0-a6e7-1027-dfb2019b8ef2@linux.intel.com> <20171129070951.hjjjpbyilzaak4ig@gmail.com> <20171129124711.slmq5emx4f26c4zp@hirez.programming.kicks-ass.net>
To:     Peter Zijlstra <peterz@infradead.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Nov 29, 2017, at 4:47 AM, Peter Zijlstra <peterz@infradead.org> wrote:
>=20
>> On Wed, Nov 29, 2017 at 08:09:51AM +0100, Ingo Molnar wrote:
>> diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
>> index f81d50d7ceac..c0b52df8ee4f 100644
>> --- a/arch/x86/entry/entry_64.S
>> +++ b/arch/x86/entry/entry_64.S
>> @@ -945,16 +945,16 @@ idtentry simd_coprocessor_error        do_simd_copr=
ocessor_error    has_error_code=3D0
>>     */
>> ENTRY(native_load_gs_index)
>>    FRAME_BEGIN
>> +    SWAPGS                    /* switch from user GS to kernel GS */
>>    pushfq
>>    DISABLE_INTERRUPTS(CLBR_ANY & ~CLBR_RDI)
>>    TRACE_IRQS_OFF
>> -    SWAPGS
>=20
> I'm thinking those moves it too far back; we should at least have
> interrupts disabled when we do SWAPGS, no? Also, curse paravirt.
>=20

I'll look in a few hours.

But we definitely can't have irqs on when running with user gs.=

From 1585425215511738930@xxx Wed Nov 29 18:15:08 +0000 2017
X-GM-THRID: 1585383480543829622
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread