Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Andy Lutomirski' <luto@amacapital.net>,
        Peter Zijlstra <peterz@infradead.org>
CC:     Ingo Molnar <mingo@kernel.org>,
        Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Borislav Petkov <bp@alien8.de>
Subject: RE: [PATCH] x86/entry/64: Fix native_load_gs_index() SWAPGS handling
 with IRQ state tracing enabled
Thread-Topic: [PATCH] x86/entry/64: Fix native_load_gs_index() SWAPGS handling
 with IRQ state tracing enabled
Thread-Index: AQHTaR8fKskq+GLGsUC5ju1OFMHHkKMrb/rw
Date:   Wed, 29 Nov 2017 14:56:43 +0000
Message-ID: <4f2c1cf45fd04e83a7d360d0d602830e@AcuMS.aculab.com>
References: <0fede9f9-88b0-a6e7-1027-dfb2019b8ef2@linux.intel.com>
 <20171129070951.hjjjpbyilzaak4ig@gmail.com>
 <20171129124711.slmq5emx4f26c4zp@hirez.programming.kicks-ass.net>
 <D6A6B532-57B5-4393-A322-DD441BEE74C4@amacapital.net>
In-Reply-To: <D6A6B532-57B5-4393-A322-DD441BEE74C4@amacapital.net>
Accept-Language: en-GB, en-US
Content-Language: en-US
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-Authenticated_ID: 
X-PolicySMART: 3396946, 3397078
X-Virus-Status: Scanned by VirusSMART (c)
X-Virus-Status: Scanned by VirusSMART (s)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Andy Lutomirski
> Sent: 29 November 2017 14:34
> > On Nov 29, 2017, at 4:47 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> >
> >> On Wed, Nov 29, 2017 at 08:09:51AM +0100, Ingo Molnar wrote:
> >> diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
> >> index f81d50d7ceac..c0b52df8ee4f 100644
> >> --- a/arch/x86/entry/entry_64.S
> >> +++ b/arch/x86/entry/entry_64.S
> >> @@ -945,16 +945,16 @@ idtentry simd_coprocessor_error        do_simd_coprocessor_error
> has_error_code=0
> >>     */
> >> ENTRY(native_load_gs_index)
> >>    FRAME_BEGIN
> >> +    SWAPGS                    /* switch from user GS to kernel GS */
> >>    pushfq
> >>    DISABLE_INTERRUPTS(CLBR_ANY & ~CLBR_RDI)
> >>    TRACE_IRQS_OFF
> >> -    SWAPGS
> >
> > I'm thinking those moves it too far back; we should at least have
> > interrupts disabled when we do SWAPGS, no? Also, curse paravirt.
> >
> 
> I'll look in a few hours.
> 
> But we definitely can't have irqs on when running with user gs.

I can't remember what happens when swapgs itself faults.
I'm pretty sure it can, restoring %ds %es and %fs can definitely fault
(especially for 32 bit apps) if the restored values are invalid.
With user LDT I think it is possible for a valid segment register
to become invalid while a process is sleeping.
The debugger (and possible a signal handler) can set the segment
registers to arbitrary values - so loading them faults.

I fixed NetBSD a few years ago so that all these faults were handled
correctly.

	David


From 1585404210277459895@xxx Wed Nov 29 12:41:16 +0000 2017
X-GM-THRID: 1585383480543829622
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread