Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757954AbYAJWWK (ORCPT ); Thu, 10 Jan 2008 17:22:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754401AbYAJWV4 (ORCPT ); Thu, 10 Jan 2008 17:21:56 -0500 Received: from srv5.dvmed.net ([207.36.208.214]:55244 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbYAJWVz (ORCPT ); Thu, 10 Jan 2008 17:21:55 -0500 Message-ID: <47869A7D.2020703@pobox.com> Date: Thu, 10 Jan 2008 17:21:49 -0500 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Tejun Heo CC: Ondrej Zary , linux-ide@vger.kernel.org, Linux Kernel Subject: Re: [PATCH] libata and starting/stopping ATAPI floppy devices References: <200801051647.58866.linux@rainbow-software.org> <4784344C.5060208@gmail.com> <200801091853.15601.linux@rainbow-software.org> <47855B99.3080302@gmail.com> In-Reply-To: <47855B99.3080302@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.3 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1408 Lines: 41 Tejun Heo wrote: > From: Ondrej Zary > > Prevent libata from starting/stopping non-ATA devices (like ATAPI floppy > drives) as they don't seem to like it: > > sd 1:0:1:0: [sdb] Starting disk > ata2.01: configured for PIO2 > sd 1:0:1:0: [sdb] Result: hostbyte=0x00 driverbyte=0x08 > sd 1:0:1:0: [sdb] Sense Key : 0x2 [current] > sd 1:0:1:0: [sdb] ASC=0x3a ASCQ=0x0 > > Signed-off-by: Ondrej Zary > Signed-off-by: Tejun Heo > --- > Trimmed message body and reformatted such that it's script friendly. > > drivers/ata/libata-scsi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- linux-2.6.23-orig/drivers/ata/libata-scsi.c 2007-10-09 22:31:38.000000000 +0200 > +++ linux-2.6.23-pentium/drivers/ata/libata-scsi.c 2008-01-05 15:50:16.000000000 +0100 > @@ -802,7 +802,8 @@ > > blk_queue_max_phys_segments(sdev->request_queue, LIBATA_MAX_PRD); > > - sdev->manage_start_stop = 1; > + if (dev->class == ATA_DEV_ATA) > + sdev->manage_start_stop = 1; > > if (dev) applied #upstream-fixes manually. not sure why git-am didn't like it, but patch(1) did. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/