Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 28 Nov 2017 17:08:40 -0800
From:   Jakub Kicinski <kubakici@wp.pl>
To:     Matthew Wilcox <willy@infradead.org>
Cc:     Matthew Wilcox <mawilcox@microsoft.com>,
        Chris Mi <chrism@mellanox.com>, Jiri Pirko <jiri@mellanox.com>,
        "David S . Miller" <davem@davemloft.net>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Eric Biggers <ebiggers@google.com>,
        Lai Jiangshan <laijs@cn.fujitsu.com>,
        Tejun Heo <tj@kernel.org>, Rehas Sachdeva <aquannie@gmail.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/17] cls_bpf: Convert to use idr_alloc_u32
Message-ID: <20171128170817.1c23d420@cakuba.netronome.com>
In-Reply-To: <20171128213312.28983-12-willy@infradead.org>
References: <20171128213312.28983-1-willy@infradead.org>
        <20171128213312.28983-12-willy@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 28 Nov 2017 13:33:06 -0800, Matthew Wilcox wrote:
> +		ret = idr_alloc_u32(&head->handle_idr, prog, &handle,
> +						INT_MAX, GFP_KERNEL);
> +	} else if (!oldprog) {
> +		ret = idr_alloc_u32(&head->handle_idr, prog, &handle,
> +						handle, GFP_KERNEL);

nit: in many places you seem to not align the second line with opening
parenthesis.  Is that intentional?

FWIW there may be a small merge conflict with net on cls_bpf in patch
5, some of the code has been removed.

From 1585347242762717100@xxx Tue Nov 28 21:35:48 +0000 2017
X-GM-THRID: 1585347242762717100
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread