Date: Fri, 11 Jan 2008 00:28:12 +0100
From: Jan Kara <jack@suse.cz>
To: marcin.slusarz@gmail.com
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 15/16] udf: fix udf_debug macro
Message-ID: <20080110232812.GH17430@duck.suse.cz>
References: <1200002792-8449-1-git-send-email-marcin.slusarz@gmail.com> <1200002792-8449-16-git-send-email-marcin.slusarz@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1200002792-8449-16-git-send-email-marcin.slusarz@gmail.com>
User-Agent: Mutt/1.5.16 (2007-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1317
Lines: 46

On Thu 10-01-08 23:06:31, marcin.slusarz@gmail.com wrote:
> udf_debug should be enclosed with do { } while (0)
> to be safely used in code like below:
> if (something)
> 	udf_debug();
> else
> 	anything;
> (Otherwise compiler will not compile it with:
> "error: expected expression before 'else'")
> 
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> CC: Jan Kara <jack@suse.cz>
> ---
>  include/linux/udf_fs.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/udf_fs.h b/include/linux/udf_fs.h
> index 36c684e..c954527 100644
> --- a/include/linux/udf_fs.h
> +++ b/include/linux/udf_fs.h
> @@ -39,11 +39,11 @@
>  
>  #ifdef UDFFS_DEBUG
>  #define udf_debug(f, a...) \
> -	{ \
> +	do { \
>  		printk (KERN_DEBUG "UDF-fs DEBUG %s:%d:%s: ", \
>  			__FILE__, __LINE__, __FUNCTION__); \
>  		printk (f, ##a); \
> -	}
> +	} while (0)
>  #else
>  #define udf_debug(f, a...) /**/
>  #endif
  Actually, in that case you should also change /**/ to
  do {} while (0)

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/