Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 29 Nov 2017 16:11:40 -0500 (EST)
From:   Alan Stern <stern@rowland.harvard.edu>
To:     Mikhail Zaytsev <flashed@mail.ru>
cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-usb@vger.kernel.org>,
        <usb-storage@lists.one-eyed-alien.net>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] USB: storage: Notify the subdrivers that they need
 to reinitialize the device.
In-Reply-To: <20171130000353.6de42104@debian>
Message-ID: <Pine.LNX.4.44L0.1711291610360.1369-100000@iolanthe.rowland.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 30 Nov 2017, Mikhail Zaytsev wrote:

> On Wed, 29 Nov 2017 Alan Stern <stern@rowland.harvard.edu> wrote:
> 
> > On Wed, 29 Nov 2017, Mikhail Zaytsev wrote:
> > 
> > > This patch adds the device_reinit function into the us_data
> > > structure. The usb-storage driver uses this function for notify the
> > > subdrivers that they need to reinitialize the device.
> > > 
> > > Signed-off-by: Mikhail Zaytsev <flashed@mail.ru>  
> > 
> > I'd feel more inclined to accept this patch if the new code got used 
> > somewhere.  As it is, it fixes a "problem" that doesn't actually have 
> > any real effect.
> > 
> > Alan Stern
> 
> I propose to delete this FIXME comments without any code changes.

Okay.  You could leave a comment saying that if any of the subdrivers 
implemented a reinitialization scheme, this is where the callback would 
be invoked.

Alan Stern


From 1585435892132788715@xxx Wed Nov 29 21:04:50 +0000 2017
X-GM-THRID: 1585404912485663017
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread