Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20171127114159.2528123-1-arnd@arndb.de>
References: <20171127114159.2528123-1-arnd@arndb.de>
From:   Pravin Shelar <pshelar@ovn.org>
Date:   Tue, 28 Nov 2017 10:29:56 +0530
Message-ID: <CAOrHB_AqrW=46=YbyMi8LvoFmcTvFXD8epTmJz5DmBNTqOGiCw@mail.gmail.com>
Subject: Re: [PATCH] openvswitch: use ktime_get_ts64() instead of ktime_get_ts()
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Pravin Shelar <pshelar@nicira.com>,
        "David S. Miller" <davem@davemloft.net>, y2038@lists.linaro.org,
        Tonghao Zhang <xiangxia.m.yue@gmail.com>,
        Jiri Benc <jbenc@redhat.com>,
        Willem de Bruijn <willemb@google.com>,
        Jarno Rajahalme <jarno@ovn.org>,
        Yi-Hung Wei <yihung.wei@gmail.com>,
        Yi Yang <yi.y.yang@intel.com>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        ovs dev <dev@openvswitch.org>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Nov 27, 2017 at 5:11 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> timespec is deprecated because of the y2038 overflow, so let's convert
> this one to ktime_get_ts64(). The code is already safe even on 32-bit
> architectures, since it uses monotonic times. On 64-bit architectures,
> nothing changes, while on 32-bit architectures this avoids one
> type conversion.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  net/openvswitch/flow.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c
> index dbe2379329c5..76d050aba7a4 100644
> --- a/net/openvswitch/flow.c
> +++ b/net/openvswitch/flow.c
> @@ -56,12 +56,12 @@
>
>  u64 ovs_flow_used_time(unsigned long flow_jiffies)
>  {
> -       struct timespec cur_ts;
> +       struct timespec64 cur_ts;
>         u64 cur_ms, idle_ms;
>
> -       ktime_get_ts(&cur_ts);
> +       ktime_get_ts64(&cur_ts);
>         idle_ms = jiffies_to_msecs(jiffies - flow_jiffies);
> -       cur_ms = (u64)cur_ts.tv_sec * MSEC_PER_SEC +
> +       cur_ms = (u64)(u32)cur_ts.tv_sec * MSEC_PER_SEC +

I am not sure why is tv_sec converted to u32.

>                  cur_ts.tv_nsec / NSEC_PER_MSEC;
>
>         return cur_ms - idle_ms;
> --
> 2.9.0
>

From 1585219465523485672@xxx Mon Nov 27 11:44:50 +0000 2017
X-GM-THRID: 1585219465523485672
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread