Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20171024122556.15872-2-brendan.jackman@arm.com>
References: <20171024122556.15872-1-brendan.jackman@arm.com> <20171024122556.15872-2-brendan.jackman@arm.com>
From:   Todd Kjos <tkjos@android.com>
Date:   Thu, 9 Nov 2017 11:56:07 -0800
Message-ID: <CAD0t5oPxXc1XARh8puEThJQYfRNFAc2Su0Bj1bDH7_77MVczzA@mail.gmail.com>
Subject: Re: [PATCH 1/2] sched: force update of blocked load of idle cpus
To:     Brendan Jackman <brendan.jackman@arm.com>
Cc:     Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@redhat.com>,
        Morten Rasmussen <morten.rasmussen@arm.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> @@ -8683,6 +8692,10 @@ static void nohz_balancer_kick(void)
>
>         if (test_and_set_bit(NOHZ_BALANCE_KICK, nohz_flags(ilb_cpu)))
>                 return;
> +
> +       if (only_update)
> +               set_bit(NOHZ_STATS_KICK, nohz_flags(ilb_cpu));

Should there be an "else clear_bit(NOHZ_STATS_KICK, nohz_flags(ilb_cpu));" ?

Seems like any time this is called as !only_update, we should stop
inhibiting rebalance. In fact, we should perhaps go a little further
so that an only_update never inhibits rebalance from a concurrent
!only_update.

From 1582141822627669982@xxx Tue Oct 24 12:27:01 +0000 2017
X-GM-THRID: 1582141822627669982
X-Gmail-Labels: Inbox,Category Forums