Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 28 Nov 2017 16:13:08 +0100 (CET)
From:   Thomas Voegtle <tv@lio96.de>
To:     Daniel Vetter <daniel@ffwll.ch>
cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org,
        stable@vger.kernel.org
Subject: Re: [PATCH] drm/fb_helper: Disable all crtc's when initial setup
 fails.
In-Reply-To: <20171128114943.dn4hpgxb6st3ng23@phenom.ffwll.local>
Message-ID: <alpine.LSU.2.20.1711281603210.10192@er-systems.de>
References: <alpine.LSU.2.20.1711281123060.17234@er-systems.de> <20171128111603.62757-1-maarten.lankhorst@linux.intel.com> <20171128114943.dn4hpgxb6st3ng23@phenom.ffwll.local>
User-Agent: Alpine 2.20 (LSU 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 28 Nov 2017, Daniel Vetter wrote:

> On Tue, Nov 28, 2017 at 12:16:03PM +0100, Maarten Lankhorst wrote:
>> Some drivers like i915 start with crtc's enabled, but with deferred
>> fbcon setup they were no longer disabled as part of fbdev setup.
>> Headless units could no longer enter pc3 state because the crtc was
>> still enabled.
>>
>> Fix this by calling restore_fbdev_mode when we would have called
>> it otherwise once during initial fbdev setup.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Fixes: ca91a2758fce ("drm/fb-helper: Support deferred setup")
>
> Please use dim fixes to get a more complete Cc: list for regression fixes.
>
>> Cc: <stable@vger.kernel.org> # v4.14+
>> Reported-by: Thomas Voegtle <tv@lio96.de>
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> But please confirm with the reporter that it indeed fixes the issue before
> pushing.
> -Daniel

I re-checked the latest version of the patch and it indeed fixes the 
problem.

Thanks,

    Thomas


From 1585310495336953987@xxx Tue Nov 28 11:51:42 +0000 2017
X-GM-THRID: 1585308911762252648
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread