Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757340AbYAKCSh (ORCPT ); Thu, 10 Jan 2008 21:18:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753373AbYAKCS1 (ORCPT ); Thu, 10 Jan 2008 21:18:27 -0500 Received: from hs-out-0708.google.com ([64.233.178.240]:15242 "EHLO hs-out-2122.google.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751035AbYAKCS0 (ORCPT ); Thu, 10 Jan 2008 21:18:26 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=KMnwZqDlsUbjw4jWSFWirgHEMoNROzZkakfevPG5caND5FVnt1VF/eIcn/qLx0tMdwL1zR2aVYx9kKfKnWIvPlk4D8TOywqbj6L4fXGrwxEkqWZS+GKSwFkX9L78gVa+O0VujdFza+nNtuh1C3ofY+YBOhsI/3bgMdc6j1OkoJU= Message-ID: Date: Fri, 11 Jan 2008 10:18:24 +0800 From: "Dave Young" To: "Stefan Richter" Subject: Re: [PATCH 0/7] convert semaphore to mutex in struct class Cc: "Greg KH" , James.Bottomley@hansenpartnership.com, linux-scsi@vger.kernel.org, a.zummo@towertech.it, peterz@infradead.org, cbou@mail.ru, linux-kernel@vger.kernel.org, "David Brownell" , krh@redhat.com, stern@rowland.harvard.edu, rtc-linux@googlegroups.com, spi-devel-general@lists.sourceforge.net, linux1394-devel@lists.sourceforge.net, dwmw2@infradead.org, davem@davemloft.net, jarkao2@gmail.com In-Reply-To: <478610E8.4060602@s5r6.in-berlin.de> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <478227D5.8050402@s5r6.in-berlin.de> <20080107172009.GA25943@suse.de> <20080108224837.GA19623@suse.de> <20080109061316.GA3249@darkstar.te-china.tietoenator.com> <20080110094843.GA3014@darkstar.te-china.tietoenator.com> <478610E8.4060602@s5r6.in-berlin.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2191 Lines: 71 On Jan 10, 2008 8:34 PM, Stefan Richter wrote: > Dave Young wrote: > > This is the first one of the series about driver core changes. > > Please always provide kerneldoc comments when you add new API elements; > here: exported functions. > > It's unfortunate that the driver core's API isn't fully documented yet, > and you shouldn't make it worse. > > That's only my personal opinion as one API user though. But others > might agree. Among else, things worth documenting are return values > after errors, side effects (!), constraints on the calling context if > there are any special constraints. > > I assume you didn't write documentation yet because you need general > feedback first. Yes, I did not. Thanks for pointing out, I will do. > > ... > > +struct device *class_find_device(struct class *class, void *data, > > + int (*match)(struct device *, void *)) > > +{ > > + struct device *dev; > > + > > + if (!class) > > + return NULL; > > + > > + mutex_lock(&class->mutex); > > + list_for_each_entry(dev, &class->devices, node) > > + if (match(dev, data) && get_device(dev)) > > + break; > > + mutex_unlock(&class->mutex); > > + > > + return dev; > > +} > > What is returned if there was no match? > What if there was a match but get_ failed? Will fix it. > > ... > > +struct class_device *class_find_child(struct class *class, void *data, > > + int (*match)(struct class_device *, void *)) > > +{ > ... > > + mutex_lock(&class->mutex); > > + list_for_each_entry(dev, &class->children, node) > > + if (match(dev, data) && class_device_get(dev)) > > + break; > > + mutex_unlock(&class->mutex); > > + > > + return dev; > > +} > > Here too? Will fix it. > > -- > Stefan Richter > -=====-==--- ---= -=-=- > http://arcgraph.de/sr/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/