Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 31 Oct 2017 14:37:32 -0700
From:   Davidlohr Bueso <dave@stgolabs.net>
To:     Waiman Long <longman@redhat.com>
Cc:     Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.com>,
        Jeff Layton <jlayton@poochiereds.net>,
        "J. Bruce Fields" <bfields@fieldses.org>,
        Tejun Heo <tj@kernel.org>,
        Christoph Lameter <cl@linux-foundation.org>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andi Kleen <andi@firstfloor.org>,
        Dave Chinner <dchinner@redhat.com>,
        Boqun Feng <boqun.feng@gmail.com>
Subject: Re: [PATCH v8 1/6] lib/dlock-list: Distributed and lock-protected
 lists
Message-ID: <20171031213732.2nqqbdefvxxorg52@linux-n805>
References: <1509475860-16139-1-git-send-email-longman@redhat.com>
 <1509475860-16139-2-git-send-email-longman@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <1509475860-16139-2-git-send-email-longman@redhat.com>
User-Agent: NeoMutt/20170421 (1.8.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 31 Oct 2017, Waiman Long wrote:

>+void dlock_lists_del(struct dlock_list_node *node)
>+{
>+	struct dlock_list_head *head;
>+	bool retry;
>+
>+	do {
>+		head = READ_ONCE(node->head);

Boqun had previously pointed this out; you need to WRITE_ONCE() node->head too.

Thanks,
Davidlohr

From 1582800381820199218@xxx Tue Oct 31 18:54:32 +0000 2017
X-GM-THRID: 1582800381820199218
X-Gmail-Labels: Inbox,Category Forums