Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 30 Nov 2017 07:52:42 -0500
From:   Josh Abraham <j.abraham1776@gmail.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     arnaud.patard@rtp-net.org, kstewart@linuxfoundation.org,
        devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, pombredanne@nexb.com,
        tglx@linutronix.de
Subject: Re: [PATCH] staging: xgifb: remove unused macro XGIPART3
Message-ID: <20171130125242.GA20957@josharch>
References: <20171130025348.GA11487@josharch>
 <20171130055544.zumzsypzwzssozts@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171130055544.zumzsypzwzssozts@mwanda>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 30, 2017 at 08:55:44AM +0300, Dan Carpenter wrote:
> On Wed, Nov 29, 2017 at 09:53:48PM -0500, Joshua Abraham wrote:
> > Signed-off-by: Joshua Abraham <j.abraham1776@gmail.com>
> > 
> > This patch removes the unused macro XGIPART3.
> > 
> 
> The Signed-off-by line goes after the changelog.
> 
> > ---
> >  drivers/staging/xgifb/XGI_main.h | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/staging/xgifb/XGI_main.h b/drivers/staging/xgifb/XGI_main.h
> > index a3af1cbbf8ee..5f55d0a39bc1 100644
> > --- a/drivers/staging/xgifb/XGI_main.h
> > +++ b/drivers/staging/xgifb/XGI_main.h
> > @@ -25,7 +25,6 @@ MODULE_DEVICE_TABLE(pci, xgifb_pci_table);
> >  #define XGIDACD			  (xgifb_info->dev_info.P3c9)
> >  #define XGIPART1		  (xgifb_info->dev_info.Part1Port)
> >  #define XGIPART2		  (xgifb_info->dev_info.Part2Port)
> > -#define XGIPART3		  (xgifb_info->dev_info.Part3Port)
> 
> That define isn't hurting anyone.
> 
> >  #define XGIPART4		  (xgifb_info->dev_info.Part4Port)
> >  #define XGIPART5		  (xgifb_info->dev_info.Part5Port)
> 
> Actually these should all be deleted because they mean you have to have
> a xgifb_info variable and they hurt readability by hiding stuff behind a
> define.  It would be better to remove them all than to just remove one
> from the middle.  That's a more complicated patch, but it's a useful
> patch.
> 
> regards,
> dan carpenter
> 

Great point.  I will work on that and get the patch out!

-Josh

From 1585469361323793426@xxx Thu Nov 30 05:56:49 +0000 2017
X-GM-THRID: 1585457880475547553
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread