Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/2] mfd: cros ec: spi: Don't send first message too soon
To:     Brian Norris <briannorris@chromium.org>
CC:     Lee Jones <lee.jones@linaro.org>, <linux-kernel@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>,
        Shawn Nematbakhsh <shawnn@chromium.org>,
        Benson Leung <bleung@chromium.org>,
        Doug Anderson <dianders@chromium.org>
References: <1510607140-30582-1-git-send-email-jonathanh@nvidia.com>
 <20171113211900.GA126873@google.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <1ef0189a-13b1-b35d-27b9-61b5f77a1795@nvidia.com>
Date:   Tue, 14 Nov 2017 14:44:31 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171113211900.GA126873@google.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 13/11/17 21:19, Brian Norris wrote:
> + others
> 
> On Mon, Nov 13, 2017 at 09:05:39PM +0000, Jon Hunter wrote:
>> On the Tegra124 Nyan-Big chromebook the very first SPI message sent to
>> the EC is failing.
>>
>> The Tegra SPI driver configures the SPI chip-selects to be active-high
>> by default (and always has for many years). The EC SPI requires an
>> active-low chip-select and so the Tegra chip-select is reconfigured to
>> be active-low when the EC SPI driver calls spi_setup(). The problem is
>> that if the first SPI message to the EC is sent too soon after
>> reconfiguring the SPI chip-select, it fails.
>>
>> The EC SPI driver prevents back-to-back SPI messages being sent too
>> soon by keeping track of the time the last transfer was sent via the
>> variable 'last_transfer_ns'. To prevent the very first transfer being
>> sent too soon, initialise the 'last_transfer_ns' variable after calling
>> spi_setup() and before sending the first SPI message.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>> Looks like this issue has been around for several Linux releases now
>> and it just depends on timing if this issue is seen or not and so there
>> is no specific commit this fixes. However, would be good to include for
>> v4.15.
> 
> I wonder if that doesn't mean we should have a stable tag still?
> 
> Cc: <stable@vger.kernel.org>

I was thinking about that as well after I sent it. I have resent as a V2
CC'ing stable.

Cheers
Jon

-- 
nvpublic

From 1583987345099498822@xxx Mon Nov 13 21:20:48 +0000 2017
X-GM-THRID: 1583986551346950245
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread