Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 29 Nov 2017 12:11:23 +0000
From:   Lee Jones <lee.jones@linaro.org>
To:     Shawn Nematbakhsh <shawnn@chromium.org>
Cc:     linux-kernel@vger.kernel.org, jonathanh@nvidia.com,
        briannorris@chromium.org
Subject: Re: [PATCH] mfd: cros ec: spi: Fix "in progress" error signaling
Message-ID: <20171129121123.7zg63mjy7pufokg5@dell>
References: <20170927213527.31416-1-shawnn@chromium.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20170927213527.31416-1-shawnn@chromium.org>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 27 Sep 2017, Shawn Nematbakhsh wrote:

> For host commands that take a long time to process, cros ec can return
> early by signaling a EC_RES_IN_PROGRESS result. The host must then poll
> status with EC_CMD_GET_COMMS_STATUS until completion of the command.
> 
> None of the above applies when data link errors are encountered. When
> errors such as EC_SPI_PAST_END are encountered during command
> transmission, it usually means the command was not received by the EC.
> Treating such errors as if they were 'EC_RES_IN_PROGRESS' results is
> almost always the wrong decision, and can result in host commands
> silently being lost.
> 
> Reported-and-tested-by: Jon Hunter <jonathanh@nvidia.com>
> Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
> ---
>  drivers/mfd/cros_ec_spi.c | 52 ++++++++++++++++++++++-------------------------
>  1 file changed, 24 insertions(+), 28 deletions(-)

Applied, thanks.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

From 1585401129148958358@xxx Wed Nov 29 11:52:18 +0000 2017
X-GM-THRID: 1579730367073760625
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread