Received: by 10.223.164.202 with SMTP id h10csp4270740wrb;
        Wed, 29 Nov 2017 03:52:17 -0800 (PST)
X-Google-Smtp-Source: AGs4zMYH4Z3BhaPK91ta2ZfnqQaDSGq8t77dTWjgDZ7Fzw+NNu27msYBb0C5py5/u+2t4F1x/1du
X-Received: by 10.98.181.25 with SMTP id y25mr2742167pfe.206.1511956337879;
        Wed, 29 Nov 2017 03:52:17 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1511956337; cv=none;
        d=google.com; s=arc-20160816;
        b=FOxIrNdylXrf+isv4pPZ/0c4KIm5pTzjeiXrLht95SaacIL08Pq6+3OswU+qk5Na17
         2BvTAh0hS5M1Pgq40NJmbQXpY9RFIF5dyglItHikIgxIb5Vlbpl506WkPpz1znjRfkEw
         m3Nir+5jdeCdozpbNPyVs86llInPm5m/bpimA5U1CnZg/hkOlepUFggqbEo1QjJ26UmI
         MtXjB24oy5Qn31Ir1X1eqvrkoxkNIb2lKzsKXRoSe7lX5p2bkmKIMjtYnYGHFIYiqOX1
         51G8z8TafVu7VltDmIPIjLH5shkS+kPVFGl86omQEifCZweNjEKm3Ji/pW3Q/n7DihQD
         x23A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject:arc-authentication-results;
        bh=aJ/pbqqxCxNJ5Ptg3xD/wkDa3YeY47KKcduIaSYmx/Y=;
        b=dkAPmXWYKZJ9joLyxIBqfOlEvgcXf0X+WnKcJxkV2dioa4GxkWXJuh1uoyAqzIYwL6
         Ip2ZUHdeWL+DhdFX7DCFF3Oj/GHzmPNIvWYIV7uv+3InIjPYb7Nn788eyzkKlduEzoKS
         iaYFWT2othpw8fvM6jKqfi6s2OYeEzBxuXGBy+031fUkFJNHBQkKdVOgi6vsZS2+ndXk
         X8yHA7ebEvWNlRoEb39Vrh4alx9to64Bl4v+w/atdUjPKl5XL/iri8gUVa4cMuVs3znC
         uf31xONfOtIaK12RFLE3PYZgJAEAMKS22bspdCCjQfCAmU89UTQ5qNqcbGPf0Dkm/gMd
         xFVA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id t69si1150274pgc.603.2017.11.29.03.52.07;
        Wed, 29 Nov 2017 03:52:17 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754666AbdK2LuV (ORCPT <rfc822;c14006078@gmail.com> + 70 others);
        Wed, 29 Nov 2017 06:50:21 -0500
Received: from hqemgate16.nvidia.com ([216.228.121.65]:9553 "EHLO
        hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753232AbdK2LuU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 29 Nov 2017 06:50:20 -0500
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com
        id <B5a1e9eff0000>; Wed, 29 Nov 2017 03:50:23 -0800
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Wed, 29 Nov 2017 03:51:01 -0800
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Wed, 29 Nov 2017 03:51:01 -0800
Received: from UKMAIL101.nvidia.com (10.26.138.13) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1293.2; Wed, 29 Nov
 2017 11:50:19 +0000
Received: from [10.21.132.148] (10.21.132.148) by UKMAIL101.nvidia.com
 (10.26.138.13) with Microsoft SMTP Server (TLS) id 15.0.1293.2; Wed, 29 Nov
 2017 11:50:16 +0000
Subject: Re: [PATCH] mfd: cros ec: spi: Fix "in progress" error signaling
To:     Lee Jones <lee.jones@linaro.org>
CC:     Shawn N <shawnn@chromium.org>,
        Brian Norris <briannorris@chromium.org>,
        <linux-kernel@vger.kernel.org>, Benson Leung <bleung@chromium.org>
References: <20170927213527.31416-1-shawnn@chromium.org>
 <20170927221908.GA7699@google.com>
 <CALaWCOOPJ-Pp7RF=c7Uz60MTCm9iz=KuEaHav5Miu4PciAD27A@mail.gmail.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <bc933b49-9990-5bdf-22b8-9c0ee2c415f4@nvidia.com>
Date:   Wed, 29 Nov 2017 11:50:15 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CALaWCOOPJ-Pp7RF=c7Uz60MTCm9iz=KuEaHav5Miu4PciAD27A@mail.gmail.com>
X-Originating-IP: [10.21.132.148]
X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com
 (10.26.138.13)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Lee,

On 14/11/17 17:00, Shawn N wrote:
> On Wed, Sep 27, 2017 at 3:19 PM, Brian Norris <briannorris@chromium.org> wrote:
>> On Wed, Sep 27, 2017 at 02:35:27PM -0700, Shawn Nematbakhsh wrote:
>>> For host commands that take a long time to process, cros ec can return
>>> early by signaling a EC_RES_IN_PROGRESS result. The host must then poll
>>> status with EC_CMD_GET_COMMS_STATUS until completion of the command.
>>>
>>> None of the above applies when data link errors are encountered. When
>>> errors such as EC_SPI_PAST_END are encountered during command
>>> transmission, it usually means the command was not received by the EC.
>>> Treating such errors as if they were 'EC_RES_IN_PROGRESS' results is
>>> almost always the wrong decision, and can result in host commands
>>> silently being lost.
>>>
>>> Reported-and-tested-by: Jon Hunter <jonathanh@nvidia.com>
>>> Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
>>> ---
>>>  drivers/mfd/cros_ec_spi.c | 52 ++++++++++++++++++++++-------------------------
>>>  1 file changed, 24 insertions(+), 28 deletions(-)
>>
>> I'm still not sure I understand the full extent of the
>> originally-reported error (it's still likely a SPI transport issue?),
>> but I believe this patch is good anyway:
>>
>> Reviewed-by: Brian Norris <briannorris@chromium.org>
> 
> Jon tracked down the root cause of the originally-reported error, but
> we should still land this patch, as it fixes error signaling that was
> previously broken.

Can you also queue this one as a fix for v4.15?

Cheers
Jon

-- 
nvpublic

From 1584736922386945423@xxx Wed Nov 22 03:55:01 +0000 2017
X-GM-THRID: 1579730367073760625
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread