Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [alsa-devel] [PATCH 1/5 v4] ASoC: ep93xx-ac97: Fix
 platform_get_irq's error checking
To:     Alexandre Belloni <alexandre.belloni@free-electrons.com>
References: <082d4479211d425219f4ab275ecc12e1011eca2f.1511062844.git.arvind.yadav.cs@gmail.com>
 <20171120133717.kscrjsb3y7gnvd2t@piout.net>
Cc:     lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
        tiwai@suse.com, matthias.bgg@gmail.com,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux@armlinux.org.uk,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
From:   arvindY <arvind.yadav.cs@gmail.com>
Message-ID: <5A12FC64.3020205@gmail.com>
Date:   Mon, 20 Nov 2017 21:31:40 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <20171120133717.kscrjsb3y7gnvd2t@piout.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Monday 20 November 2017 07:07 PM, Alexandre Belloni wrote:
> On 19/11/2017 at 09:45:00 +0530, Arvind Yadav wrote:
>> The platform_get_irq() function returns negative if an error occurs.
>> zero or positive number on success. platform_get_irq() error checking
>> for zero is not correct.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>> ---
>> changes in v2 :
>>                 irq was unsigned. so changed it to signed.
>> changes in v3 :
>>                Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
>> changes in v4 :
>>                Return -ENODEV insted of irq.
>>
> To ensure this doesn't get applied: platform_get_irq can return
> -EPROBE_DEFER and this must be handled properly.
>
> (Or maybe this has never caused anything and never failed at all and
> nobody cares).
Yes, you are right. We should retry to get an irq for device. But ASoC
  driver is not retrying. if platfore_get_irq() fail here, Driver is 
throwing an error.
and this patch is only to fix error checking which is not correct in 
Driver.

~arvind

>
>>   sound/soc/cirrus/ep93xx-ac97.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/sound/soc/cirrus/ep93xx-ac97.c b/sound/soc/cirrus/ep93xx-ac97.c
>> index bbf7a92..efeecee 100644
>> --- a/sound/soc/cirrus/ep93xx-ac97.c
>> +++ b/sound/soc/cirrus/ep93xx-ac97.c
>> @@ -365,7 +365,7 @@ static int ep93xx_ac97_probe(struct platform_device *pdev)
>>   {
>>   	struct ep93xx_ac97_info *info;
>>   	struct resource *res;
>> -	unsigned int irq;
>> +	int irq;
>>   	int ret;
>>   
>>   	info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);
>> @@ -378,7 +378,7 @@ static int ep93xx_ac97_probe(struct platform_device *pdev)
>>   		return PTR_ERR(info->regs);
>>   
>>   	irq = platform_get_irq(pdev, 0);
>> -	if (!irq)
>> +	if (irq <= 0)
>>   		return -ENODEV;
>>   
>>   	ret = devm_request_irq(&pdev->dev, irq, ep93xx_ac97_interrupt,
>> -- 
>> 2.7.4
>>
>> _______________________________________________
>> Alsa-devel mailing list
>> Alsa-devel@alsa-project.org
>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel


From 1584592453860825680@xxx Mon Nov 20 13:38:45 +0000 2017
X-GM-THRID: 1584466951025449580
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread