Received: by 10.223.164.202 with SMTP id h10csp3591122wrb; Tue, 28 Nov 2017 13:56:25 -0800 (PST) X-Google-Smtp-Source: AGs4zMbTGpyyaowVrvQn4Ijd3NQBjEaNjG/Il79iobrq9gQw1+RGQjFUUEr1EKHr20EpQN3X/dAE X-Received: by 10.101.93.66 with SMTP id e2mr596315pgt.50.1511906185522; Tue, 28 Nov 2017 13:56:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511906185; cv=none; d=google.com; s=arc-20160816; b=wASBX6Hf3Jdp+emp/DRdx5RwCQZVm2g32/0t+EMXxweqRn7k+LORXPCniJEyWIRgcF Y8RyofD+ncCHMrANjpVbvPlC/BGTe7/GrD/0B3iHh039cQme15yY+i7wIzSzKWMzftMu fXsrXnhLO//PhUfFUE9JPnhQT2GMcWGfzBGZW8oZ+tV7sz4DF5ycx1kGvlrQUnGzVbn0 Cj6b7lI2oXeUvYr3oNNVqpN9hvhHBgLhO481JIp/q163ay4KNJEAGyef5zUSHRwCJ0ht G3KrbCzkPkOQ+I66SGYSRT+P3A/fJzXxVoWexkMhMi0834Tdmpc7OeppwYGo7cKVhPgB AODw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=JI+97lWnSBz99Zz6mC9/SaCqNrQzvRlAAyCKGbDnTqM=; b=bxtG1alPEGAbcDaENVwU4yxjCXO7mvZlf/lRygMlmYswlwlGqkdW5Q2q4fhFuXKe+j EFttBdHLKSOqNnADGtcRtfTQjf2++XhrPObrug6goDGe4/S+TeOadCeXAvJw9Uww2s7+ L7koTGS3FnfVzm3pGlyR5ZWFV7yWPGQvUR3WCJhcH88laFzW1WK5lwgrnjkZf+5CKnnN lQFymX5L9V5K564UtY55IIUcwMUf510M/Y56LPK47Hkx+3xY3QdbKWKZmQPXPHTbWnX/ xGSujCGnS1Bo2AgBmNmS32U0AZHKACObcc17woLmgLgkcOll+UxSkgSawAmQ9otgrEt/ f8BQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=K/nY60uP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f67si90295pgc.640.2017.11.28.13.56.15; Tue, 28 Nov 2017 13:56:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=K/nY60uP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753207AbdK1Vym (ORCPT + 70 others); Tue, 28 Nov 2017 16:54:42 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34561 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751673AbdK1Vyk (ORCPT ); Tue, 28 Nov 2017 16:54:40 -0500 Received: by mail-wm0-f67.google.com with SMTP id y82so33590534wmg.1; Tue, 28 Nov 2017 13:54:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=JI+97lWnSBz99Zz6mC9/SaCqNrQzvRlAAyCKGbDnTqM=; b=K/nY60uPJ3FiuzBQ2DVYGgrKaWv7yuJZdrobMz9n9V935r+Wt+2CVTC+gF9s9hJJyz FlxSO84Tqd3LtVIWsD87RgtXfkgcI2LfA7vkT53K4VgbrdhmH6KdaUTIgP3wekBegFNU U70k0stXp62nFj99p8ZegrXwya74doy8urf5mrdq83PItwlXPXbmhlldPC8cy9uumUUF r1Qs/2mci+Ruj/ZbgAzx/ImGsYRkc2tYXdX5RcM3iW1rt9eia5+vl6ehwGK+mkxWTtvX SABSbUskam16YblHZz74F8eQq779v8TZROuW2OqcDXuK2pvubiLG+dX5eVC4s4TcdW38 AnTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=JI+97lWnSBz99Zz6mC9/SaCqNrQzvRlAAyCKGbDnTqM=; b=E8QBJUuUyP5Jt1062g7WafSWryukMbQw2s6CRO3T3OgP6yECSWjqPfedgSSOfoFfcm YZ+HuS6VHJznDGCvf2FOJOLfcHd4S1JDKx1itoMxIjbQQL3m0CmgeIVfeQMgbq60SmhP ju53u99XOj/IxC4NgTT7PG6BrmqfjG82vNn1QDdaEVZr1+wof0FlI9/u62KCWIkv6pa5 TO8ggWk5BwqrO6EvUw5tZgfGOhDnmarce+eVEqf3BUUa6YJJcxZeGGfwVST9qMYf6zl/ dfhfgzDPn38ZgBqUc1MD8i3vokcleN2qjEo8mfbwT/4UASZUAI39g6+VtchqUvySTko1 gUkg== X-Gm-Message-State: AJaThX62c80Ufm3sLuy+Gba5BQ9pbAlaygGj03I0gtVqeJR3MOOLbn1X yuguRe3CcLFg1kjTJq2EC3o= X-Received: by 10.28.43.7 with SMTP id r7mr814550wmr.111.1511906079067; Tue, 28 Nov 2017 13:54:39 -0800 (PST) Received: from Lappy.lan (cpc96350-rdng26-2-0-cust877.15-3.cable.virginm.net. [86.18.47.110]) by smtp.gmail.com with ESMTPSA id t4sm339607wmt.3.2017.11.28.13.54.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 28 Nov 2017 13:54:38 -0800 (PST) From: Ben Whitten To: rpurdie@rpsys.net, jacek.anaszewski@gmail.com, pavel@ucw.cz Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Ben Whitten Subject: [PATCH] Introduce a NETDEV LED trigger Date: Tue, 28 Nov 2017 21:54:17 +0000 Message-Id: <1511906058-30649-1-git-send-email-ben.whitten@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's quite useful to be able to trigger LEDs based on network activity, similar mechanisms exist in routers and gateway devices. I am looking to mainline a patch that has existed out of tree for some time in OpenWRT/LEDE. The patch has been updated and restructured and most of the issues raised in the initial submission have been addressed [1]. I am also including the netdev mailing list as it was suggested previously that if there is no activity the interval will still run and is wasteful [1] https://lkml.org/lkml/2010/11/14/116 Ben Whitten (1): leds: trigger: Introduce a NETDEV trigger .../ABI/testing/sysfs-class-led-trigger-netdev | 45 +++ drivers/leds/trigger/Kconfig | 7 + drivers/leds/trigger/Makefile | 1 + drivers/leds/trigger/ledtrig-netdev.c | 428 +++++++++++++++++++++ 4 files changed, 481 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-class-led-trigger-netdev create mode 100644 drivers/leds/trigger/ledtrig-netdev.c -- 2.7.4 From 1585948002208495573@xxx Tue Dec 05 12:44:36 +0000 2017 X-GM-THRID: 1585948002208495573 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread