Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 28 Nov 2017 10:35:42 +0000
From:   Stefan Hajnoczi <stefanha@redhat.com>
To:     Jorgen Hansen <jhansen@vmware.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org,
        gregkh@linuxfoundation.org, davem@davemloft.net,
        pv-drivers@vmware.com
Subject: Re: [PATCH] VSOCK: Don't set sk_state to TCP_CLOSE before testing it
Message-ID: <20171128103542.GC17146@stefanha-x1.localdomain>
References: <1511789372-12672-1-git-send-email-jhansen@vmware.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="+nBD6E3TurpgldQp"
Content-Disposition: inline
In-Reply-To: <1511789372-12672-1-git-send-email-jhansen@vmware.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--+nBD6E3TurpgldQp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 27, 2017 at 05:29:32AM -0800, Jorgen Hansen wrote:
> A recent commit (3b4477d2dcf2) converted the sk_state to use
> TCP constants. In that change, vmci_transport_handle_detach
> was changed such that sk->sk_state was set to TCP_CLOSE before
> we test whether it is TCP_SYN_SENT. This change moves the
> sk_state change back to the original locations in that function.
>=20
> Signed-off-by: Jorgen Hansen <jhansen@vmware.com>
> ---
>  net/vmw_vsock/vmci_transport.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Sorry, silly bug on my part!

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

--+nBD6E3TurpgldQp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEcBAEBAgAGBQJaHTv+AAoJEJykq7OBq3PIEAwH/iKcvvOLxGvjT6mIJK+mqfiJ
8+Ve54Wn2Ca3ogzBnf8lJvyv2pKpo08LK2BkGimS0A9WdY5IzB2Er3wFAbX+877p
+vXS48lL4Qy+eJpOVFYwE8wDdrcmmpG432IOoZfwMQp84ovNyjm01kwGpDFgoj4v
5/3qdNWsBkB3q9PO/HSoYgu3l1wWVuPDLyLoZSbyLmS162n8uDHSk9MMlbI3WpYj
Xu9HG4fTYk0/UGRowvS3CajARDYApBPM45HahYQ6b2mO4sdpAJs09GI361HVr/ll
4nw42YT0hDKfIPwtuYDVOp6oVnbYNzkTOxb+paZe/YoqoTdJodrNIMxsgruu7hc=
=lqK1
-----END PGP SIGNATURE-----

--+nBD6E3TurpgldQp--

From 1585226114508995365@xxx Mon Nov 27 13:30:31 +0000 2017
X-GM-THRID: 1585226114508995365
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread