Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
To:     <suzuki.poulose@arm.com>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
From:   gengdongjiu <gengdongjiu@huawei.com>
Subject: [question] extract the feature bits width to 4
Message-ID: <17ab0a11-7ca2-ff22-35d6-7446dbccc3ea@huawei.com>
Date:   Tue, 28 Nov 2017 19:17:40 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,suzuki/mark,

  very sorry to disturb you, I have a question that want to consult with you. For the CPU feature detection,
why we use extract 4 bits width for the feature match instead of the actual bits number[1]?  may be the actual hardware feature bit more than 4 bits.
thanks!

static inline int __attribute_const__
cpuid_feature_extract_field(u64 features, int field, bool sign)
{
        return cpuid_feature_extract_field_width(features, field, 4, sign);
}

static bool
feature_matches(u64 reg, const struct arm64_cpu_capabilities *entry)
{
        int val = cpuid_feature_extract_field(reg, entry->field_pos, entry->sign);

        return val >= entry->min_field_value;
}


From 1585345036808627898@xxx Tue Nov 28 21:00:44 +0000 2017
X-GM-THRID: 1585224683401482111
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread