Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] bcache: Use PTR_ERR_OR_ZERO()
To:     Vasyl Gomonovych <gomonovych@gmail.com>
Cc:     kent.overstreet@gmail.com, shli@kernel.org, mingo@kernel.org,
        axboe@fb.com, gregkh@linuxfoundation.org,
        kstewart@linuxfoundation.org, linux-bcache@vger.kernel.org,
        linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1511823900-3151-1-git-send-email-gomonovych@gmail.com>
From:   Coly Li <i@coly.li>
Message-ID: <42696b58-1a5e-8a09-42ed-93ddb4621628@coly.li>
Date:   Tue, 28 Nov 2017 11:38:30 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0)
 Gecko/20100101 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1511823900-3151-1-git-send-email-gomonovych@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 28/11/2017 7:05 AM, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/md/bcache/btree.c:1800:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>

Looks good to me. Reviewed-by: Coly Li <colyli@suse.de>

Thanks.

Coly Li

> ---
>  drivers/md/bcache/btree.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
> index 658c54b3b07a..f43e49979cb2 100644
> --- a/drivers/md/bcache/btree.c
> +++ b/drivers/md/bcache/btree.c
> @@ -1797,10 +1797,7 @@ static int bch_gc_thread(void *arg)
>  int bch_gc_thread_start(struct cache_set *c)
>  {
>  	c->gc_thread = kthread_run(bch_gc_thread, c, "bcache_gc");
> -	if (IS_ERR(c->gc_thread))
> -		return PTR_ERR(c->gc_thread);
> -
> -	return 0;
> +	return PTR_ERR_OR_ZERO(c->gc_thread);
>  }
>  
>  /* Initial partial gc */
> 

From 1585262360209647445@xxx Mon Nov 27 23:06:37 +0000 2017
X-GM-THRID: 1585262360209647445
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread