Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20171120075530.4880-1-masaki.ota@jp.alps.com>
References: <20171120075530.4880-1-masaki.ota@jp.alps.com>
From:   Jonathan Liu <net147@gmail.com>
Date:   Thu, 23 Nov 2017 21:06:57 +1100
Message-ID: <CANwerB3gM3n3qz+6nu3Y0hVLQhU-Fu0G94pxfZgj5wAfSwotxw@mail.gmail.com>
Subject: Re: Support TrackStick of Thinkpad L570
To:     Masaki Ota <012nexus@gmail.com>
Cc:     dmitry.torokhov@gmail.com, benjamin.tissoires@redhat.com,
        pali.rohar@gmail.com, aaron.ma@canonical.com, jaak@ristioja.ee,
        Masaki Ota <masaki.ota@jp.alps.com>,
        linux-input@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Masaki,

On 20 November 2017 at 18:55, Masaki Ota <012nexus@gmail.com> wrote:
> From: Masaki Ota <masaki.ota@jp.alps.com>
> - The issue is that Thinkpad L570 TrackStick does not work. Because the main interface of Thinkpad L570 device is SMBus, so ALPS overlooked PS2 interface Firmware setting of TrackStick. The detail is that TrackStick otp bit is disabled.
> - Add the code that checks 0xD7 address value. This value is device number information, so we can identify the device by checking this value.
> - If we check 0xD7 value, we need to enable Command mode and after check the value we need to disable Command mode, then we have to enable the device(0xF4 command).
> - Thinkpad L570 device number is 0x0C or 0x1D. If it is TRUE, enable ALPS_DUALPOINT flag.
>
> Signed-off-by: Masaki Ota <masaki.ota@jp.alps.com>
> ---
>  drivers/input/mouse/alps.c | 21 ++++++++++++++++++---
>  1 file changed, 18 insertions(+), 3 deletions(-)

Tested-by: Jonathan Liu <net147@gmail.com>

This fixes trackstick and physical left/middle/right mouse buttons
above touchpad on Lenovo ThinkPad E570p laptop for me.

Regards,
Jonathan

From 1584597888659386033@xxx Mon Nov 20 15:05:08 +0000 2017
X-GM-THRID: 1584570916340987763
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread