Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94E6821923
MIME-Version: 1.0
In-Reply-To: <CAKohpokvQD4Z6YY6MRG8c+hnsS=Z52X4XhyTgC5FTgf7VuaNmw@mail.gmail.com>
References: <cover.1509453284.git.viresh.kumar@linaro.org> <23ba51eaa6b52117458165dccc00a95cf8e86e1d.1509453284.git.viresh.kumar@linaro.org>
 <CAL_JsqKr7MsM6iZ_QYO=iCzXNwANEGQGDLFUEwe0Z-p2Z_aMYw@mail.gmail.com> <CAKohpokvQD4Z6YY6MRG8c+hnsS=Z52X4XhyTgC5FTgf7VuaNmw@mail.gmail.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Wed, 1 Nov 2017 15:39:51 -0500
Message-ID: <CAL_JsqK-qtAaM_Ou5NtxcWR3F_q=8rMPJUm-VqGtKhbtWe5SAQ@mail.gmail.com>
Subject: Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain
 magic values
To:     Viresh Kumar <viresh.kumar@linaro.org>
Cc:     Ulf Hansson <ulf.hansson@linaro.org>,
        Kevin Hilman <khilman@kernel.org>,
        Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
        Stephen Boyd <sboyd@codeaurora.org>,
        Rafael Wysocki <rjw@rjwysocki.net>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Rajendra Nayak <rnayak@codeaurora.org>,
        Sudeep Holla <sudeep.holla@arm.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Oct 31, 2017 at 9:17 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 31 October 2017 at 16:02, Rob Herring <robh+dt@kernel.org> wrote:
>> Why not a new property for magic values? opp-magic? Don't we want to
>> know when we have magic values?
>
> I have kept a separate property since beginning (domain-performance-state)
> and moved to using these magic values in the existing field because of the
> suggestion Kevin gave earlier.
>
> https://marc.info/?l=linux-kernel&m=149306082218001&w=2
>
> I am not sure what to do now :)

Okay, I guess reusing the properties is fine.

>> Wouldn't magic values in opp-hz get propagated to user space?
>
> The OPP core puts them in debugfs just to know how the OPPs are
> set. Otherwise, I am not sure that the power domain core/drivers would
> be exposing that to user space.

I was thinking thru the cpufreq interface, but I guess this is not for cpus.

Rob

From 1582828337716868258@xxx Wed Nov 01 02:18:52 +0000 2017
X-GM-THRID: 1582777408429643294
X-Gmail-Labels: Inbox,Category Forums