Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Steve Wise" <swise@opengridcomputing.com>
To:     "'Colin King'" <colin.king@canonical.com>,
        "'Steve Wise'" <swise@chelsio.com>,
        "'Doug Ledford'" <dledford@redhat.com>,
        "'Jason Gunthorpe'" <jgg@ziepe.ca>, <linux-rdma@vger.kernel.org>
Cc:     <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <bharat@chelsio.com>
References: <20171130133006.19699-1-colin.king@canonical.com>
In-Reply-To: <20171130133006.19699-1-colin.king@canonical.com>
Subject: RE: [PATCH] iw_cxgb4: make pointer reg_workq static
Date:   Thu, 30 Nov 2017 10:41:50 -0600
Message-ID: <00fe01d369fa$1f325890$5d9709b0$@opengridcomputing.com>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Content-Language: en-us
Thread-Index: AQH3RTnGEnie/UjMnvLYPYviJRRPY6LlaRfw
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> The pointer reg_workq is local to the source and does not need to be
> in global scope, so make it static.
> 
> Cleans up sparse warning:
> drivers/infiniband/hw/cxgb4/device.c:69:25: warning: symbol 'reg_workq'
> was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Looks correct.  This fixes a recent commit.

Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Fixes: 1c8f1da5d851 ("iw_cxgb4: Fix possible circular dependency locking warning")

Thanks,

Steve.


From 1585500645562870678@xxx Thu Nov 30 14:14:04 +0000 2017
X-GM-THRID: 1585497968592828029
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread