Message-Id: <47874E3C.76E4.0078.0@novell.com>
Date: Fri, 11 Jan 2008 10:08:44 +0000
From: "Jan Beulich" <jbeulich@novell.com>
To: "Jiri Slaby" <jirislaby@gmail.com>
Cc: "Ingo Molnar" <mingo@elte.hu>, <linux-kernel@vger.kernel.org>,
       "Jeremy Fitzhardinge" <jeremy@xensource.com>
Subject: Re: [PATCH] adjust/fix LDT handling for Xen
References: <4787436E.76E4.0078.0@novell.com> <47873959.3000102@gmail.com>
In-Reply-To: <47873959.3000102@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1177
Lines: 33

>> --- linux-2.6.24-rc7/arch/x86/kernel/ldt_32.c	2008-01-10 16:53:54.000000000 +0100
>> +++ 2.6.24-rc7-x86-xen-ldt/arch/x86/kernel/ldt_32.c	2008-01-09 13:59:50.000000000 +0100
>[...]
>> @@ -73,7 +72,7 @@ static int alloc_ldt(mm_context_t *pc, u
>>  		if (oldsize*LDT_ENTRY_SIZE > PAGE_SIZE)
>>  			vfree(oldldt);
>>  		else
>> -			kfree(oldldt);
>> +			put_page(virt_to_page(oldldt));
>>  	}
>>  	return 0;
>>  }
>> @@ -117,7 +116,7 @@ void destroy_context(struct mm_struct *m
>>  		if ((unsigned)mm->context.size*LDT_ENTRY_SIZE > PAGE_SIZE)
>>  			vfree(mm->context.ldt);
>>  		else
>> -			kfree(mm->context.ldt);
>> +			put_page(virt_to_page(mm->context.ldt));
>
>why not free_page() with all those checks if it is correct virt address which it 
>brings?

I followed the combination I found elsewhere - __get_free_page/put_page
or alloc_page/free_page. I admit that I'm unclear about when/why to use
one vs. the other pair.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/