Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To:     Joe Perches <joe@perches.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        David Howells <dhowells@redhat.com>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fat: Fix sb_rdonly() change
References: <87mv3d5x51.fsf@mail.parknet.co.jp>
        <87ine15wzx.fsf@mail.parknet.co.jp>
        <1511470178.5308.2.camel@perches.com>
Date:   Fri, 24 Nov 2017 15:07:05 +0900
In-Reply-To: <1511470178.5308.2.camel@perches.com> (Joe Perches's message of
        "Thu, 23 Nov 2017 12:49:38 -0800")
Message-ID: <873754i512.fsf@mail.parknet.co.jp>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Joe Perches <joe@perches.com> writes:

> On Thu, 2017-11-23 at 15:29 +0900, OGAWA Hirofumi wrote:
>> Ouch forgot to add stable@
>> 
>> -- 
>> commit bc98a42c1f7d0f886c0c1b75a92a004976a46d9f introduced bug.
>
> I think your commit message needs a bit more information.
>
> It'd be useful to describe that the introduction of
> sb_rdonly converted the bitwise & to a boolean and so
> this conversion and comparison was made defective.
>
> Are there any other instances of defective comparisons?

Please ask to that patch author.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

From 1584891436728444747@xxx Thu Nov 23 20:50:57 +0000 2017
X-GM-THRID: 1584838287063703440
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread