Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Reshetova, Elena" <elena.reshetova@intel.com>
To:     Alasdair G Kergon <agk@redhat.com>
CC:     "dm-devel@redhat.com" <dm-devel@redhat.com>,
        "keescook@chromium.org" <keescook@chromium.org>,
        "snitzer@redhat.com" <snitzer@redhat.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "shli@kernel.org" <shli@kernel.org>,
        "koverstreet@google.com" <koverstreet@google.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
        "linux-bcache@vger.kernel.org" <linux-bcache@vger.kernel.org>,
        "ejt@redhat.comg" <ejt@redhat.comg>,
        "kent.overstreet@gmail.com" <kent.overstreet@gmail.com>,
        Zdenek Kabelac <zkabelac@redhat.com>
Subject: RE: [dm-devel] [PATCH 3/4] dm: convert dm_dev_internal.count from
        atomic_t to refcount_t
Thread-Topic: [dm-devel] [PATCH 3/4] dm: convert dm_dev_internal.count from
        atomic_t to refcount_t
Thread-Index: AQHTZHLMw1oIU3Dii0GTg8yMWjM14aMjJJsA
Date:   Fri, 24 Nov 2017 07:36:26 +0000
Message-ID: <2236FBA76BA1254E88B949DDB74E612B802C1F07@IRSMSX102.ger.corp.intel.com>
References: <1508485059-21881-1-git-send-email-elena.reshetova@intel.com>
 <1508485059-21881-4-git-send-email-elena.reshetova@intel.com>
 <20171123154941.GA15790@agk-dp.fab.redhat.com>
In-Reply-To: <20171123154941.GA15790@agk-dp.fab.redhat.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> On Fri, Oct 20, 2017 at 10:37:38AM +0300, Elena Reshetova wrote:
> >  	} else if (dd->dm_dev->mode != (mode | dd->dm_dev->mode)) {
> >  		r = upgrade_mode(dd, mode, t->md);
> >  		if (r)
> >  			return r;
> > +		refcount_inc(&dd->count);
> >  	}
> 
> Missing here:
> 
>         else
> 		refcount_inc(&dd->count);
> 
> ?

Oh, yes, thanks for catching this! I think this got unnoticed so far and patch was merged, so I am going to send a followup patch now. 

Best Regards,
Elena.

> 
> Alasdair


From 1584872581275790590@xxx Thu Nov 23 15:51:15 +0000 2017
X-GM-THRID: 1581761449867113637
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread