Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 23 Nov 2017 15:49:41 +0000
From:   Alasdair G Kergon <agk@redhat.com>
To:     Elena Reshetova <elena.reshetova@intel.com>
Cc:     dm-devel@redhat.com, keescook@chromium.org, snitzer@redhat.com,
        peterz@infradead.org, shli@kernel.org, koverstreet@google.com,
        linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-bcache@vger.kernel.org, ejt@redhat.comg,
        kent.overstreet@gmail.com, agk@redhat.com,
        Zdenek Kabelac <zkabelac@redhat.com>
Subject: Re: [dm-devel] [PATCH 3/4] dm: convert dm_dev_internal.count from
        atomic_t to refcount_t
Message-ID: <20171123154941.GA15790@agk-dp.fab.redhat.com>
Mail-Followup-To: Elena Reshetova <elena.reshetova@intel.com>,
        dm-devel@redhat.com, keescook@chromium.org, snitzer@redhat.com,
        peterz@infradead.org, shli@kernel.org, koverstreet@google.com,
        linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-bcache@vger.kernel.org, ejt@redhat.comg,
        kent.overstreet@gmail.com, agk@redhat.com,
        Zdenek Kabelac <zkabelac@redhat.com>
References: <1508485059-21881-1-git-send-email-elena.reshetova@intel.com> <1508485059-21881-4-git-send-email-elena.reshetova@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1508485059-21881-4-git-send-email-elena.reshetova@intel.com>
Organization: Red Hat UK Ltd. Registered in England and Wales, number
        03798903. Registered Office: Peninsular House, 30-36 Monument
        Street, 4th Floor, London, England, EC3R 8NB.
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Oct 20, 2017 at 10:37:38AM +0300, Elena Reshetova wrote:
>  	} else if (dd->dm_dev->mode != (mode | dd->dm_dev->mode)) {
>  		r = upgrade_mode(dd, mode, t->md);
>  		if (r)
>  			return r;
> +		refcount_inc(&dd->count);
>  	}

Missing here:

        else
		refcount_inc(&dd->count);

?

Alasdair


From 1581761449867113637@xxx Fri Oct 20 07:41:09 +0000 2017
X-GM-THRID: 1581761449867113637
X-Gmail-Labels: Inbox,Category Forums