Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roy Pledge <roy.pledge@nxp.com>
To:     Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        Greg KH <gregkh@linuxfoundation.org>
CC:     "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "stuyoder@gmail.com" <stuyoder@gmail.com>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "marc.zyngier@arm.com" <marc.zyngier@arm.com>,
        Stuart Yoder <stuart.yoder@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "agraf@suse.de" <agraf@suse.de>,
        "Catalin Horghidan" <catalin.horghidan@nxp.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Leo Li <leoyang.li@nxp.com>,
        "Bharat Bhushan" <bharat.bhushan@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Jason Cooper <jason@lakedaemon.net>
Subject: Re: [PATCH v2] staging: fsl-mc: move bus driver out of staging
Thread-Topic: [PATCH v2] staging: fsl-mc: move bus driver out of staging
Thread-Index: AQHTH+wG8MTWniSaRk21xd0aK/lH3Q==
Date:   Mon, 6 Nov 2017 19:40:06 +0000
Message-ID: <DB6PR04MB29992D82295832B25FC3912D86500@DB6PR04MB2999.eurprd04.prod.outlook.com>
References: <20170828105405.19552-1-laurentiu.tudor@nxp.com>
 <20170831160430.GB11200@kroah.com> <20171103151711.GA22453@kroah.com>
 <5A006F97.1080409@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0200b639-708d-4452-d3db-08d5254e2ed1
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2017 19:40:06.5191
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2549
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> struct dpaa2_io {=0A=
>>           atomic_t refs;=0A=
>>=0A=
>> That's a kref, please use it instead of trying to roll your own.=0A=
>>=0A=
>> And even for this, your locking is not correct (i.e. you do not have=0A=
>> any), that needs to be fixed so that teardown works correctly.=0A=
> =0A=
> I think we can drop this refcount altogether as it's not used. Roy, any=
=0A=
> comment on this?=0A=
> =0A=
=0A=
Yes I think this refcount can be removed.  I'll make a note for when the =
=0A=
DPIO is moving out of staging but that isn't part of this patchset. =0A=
There are other cleanups needed in DPIO as well. I've been holding off =0A=
on pushing patches for that until the bus driver gets moved to try to =0A=
avoid complex patch dependencies and merge conflict confusion.=0A=

From 1583326843485671626@xxx Mon Nov 06 14:22:25 +0000 2017
X-GM-THRID: 1576972122641129236
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread