Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 27 Nov 2017 23:57:36 -0500 (EST)
From:   Chunyu Hu <chuhu@redhat.com>
Reply-To: Chunyu Hu <chuhu@redhat.com>
To:     Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
Cc:     Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Borislav Petkov <bp@alien8.de>,
        Steven Rostedt <rostedt@goodmis.org>,
        linux-kernel@vger.kernel.org
Message-ID: <736042713.31089814.1511845056722.JavaMail.zimbra@redhat.com>
In-Reply-To: <CALCETrVRWSXjSxV98rdFu1XVwS5kTfbjRRiz8vr7Cmfz0A7n-Q@mail.gmail.com>
References: <1511792499-4073-1-git-send-email-chuhu@redhat.com> <CALCETrVRWSXjSxV98rdFu1XVwS5kTfbjRRiz8vr7Cmfz0A7n-Q@mail.gmail.com>
Subject: Re: [PATCH] x86/idt: load idt early in start_secondary
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Thread-Topic: x86/idt: load idt early in start_secondary
Thread-Index: +Na7eQDP36RurJGxqmW4IqxCa/w+DA==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


----- Original Message -----
> From: "Andy Lutomirski" <luto@kernel.org>
> To: "Chunyu Hu" <chuhu@redhat.com>
> Cc: "Thomas Gleixner" <tglx@linutronix.de>, "Ingo Molnar" <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
> "Peter Zijlstra" <peterz@infradead.org>, "Andrew Lutomirski" <luto@kernel.org>, "Borislav Petkov" <bp@alien8.de>,
> "Steven Rostedt" <rostedt@goodmis.org>, linux-kernel@vger.kernel.org
> Sent: Tuesday, November 28, 2017 11:41:20 AM
> Subject: Re: [PATCH] x86/idt: load idt early in start_secondary
> 
> On Mon, Nov 27, 2017 at 6:21 AM, Chunyu Hu <chuhu@redhat.com> wrote:
> > For ap, idt is first loaded in cpu_init() with load_current_idt(),
> > that is to say, no exception can be handled before there. And then
> > the idt_table has been completed by the bp.
> >
> > While there are some WARNs which needs the UD exception handling
> > in the early boot code might be triggered when something uexpected
> > happens during boot. In that case, cpu would fail to boot as the
> > exception can't be handled. A WARNing during boot is not usually
> > meaning the system could not boot.
> >
> > One use case is when ftrace=function is setup in kernel cmdline, the
> > ftrace callback function will be called for every traced function.
> > And in my case, the first traced function is load_ucode_ap. And there
> > are WARN()s in function trace callback handling, it failed to reboot
> > as one of the WARN()s is triggered before load_current_idt() executed.
> >
> > To make WARN()s can work earlier to ap, we load the idt_table early
> > in start_secondary, and keep the second time idt load in cpu_init,
> > as there is a load_ucode_ap() there.
> 
> Reviewed-by: Andy Lutomirski <luto@kernel.org>
> 
> Except that this is presumably missing a Cc: stable.

Do I need to resend this origin version and Cc stable?

> 

-- 
Regards,
Chunyu Hu


From 1585279783484351041@xxx Tue Nov 28 03:43:33 +0000 2017
X-GM-THRID: 1585229408718588005
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread