Received: by 10.223.164.202 with SMTP id h10csp2508221wrb; Mon, 27 Nov 2017 18:52:53 -0800 (PST) X-Google-Smtp-Source: AGs4zMajgh55j/s2L2s66eQUeYNEOZ/pPaNNJQMMPOK+rsB3BPc0sBKLr+oOgiM25j9paX6dSgUy X-Received: by 10.84.195.228 with SMTP id j91mr35973155pld.120.1511837573819; Mon, 27 Nov 2017 18:52:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511837573; cv=none; d=google.com; s=arc-20160816; b=ktOu3jJmxfxGV+6LLSfI8Ac0VzMyNJWiHc5caaVK1rIddJd0LQVuYpU6+YIx+aBIv7 PyT6+XPcxsV6vUJYEYqwo8qd+WSOpzWPDcRojR7mhojbDLSPrm5dmIZ7wcYQt+ObRMIp A5NdvOLWMeKYx5qT+tKk1VAF1xjs8sGXx/Oh0/puRM3rtnPcLOVN4e2wl4bNDihKaTH4 WOUHOQfkK3Cks17/rHI4GQHuTRAq9qlPmCnPO7bo7iBdw+/HOeSYMYz+zNAK22qECAAT Yfw5N0UCGHnlsnHE75sYdjxx8axagdjwCYohjmLEAnzKHfHPCGJIwQvtT1NEB7sJCOgq XPEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :references:subject:cc:to:mime-version:user-agent:from:date :message-id:arc-authentication-results; bh=b0X65ts7WP1+FOJ5Y3abJvnUYc6t5at30CXH/1DF7hU=; b=pdhs107SBkWzmZhZnKzwB8Oml0JuC5gla9TqxTq5P8BvzSplxkqpwk/Llp4E/FpBtM Faa+gx79cbfhGbkRTd4D/mVt4VO++rG3d03QJb15r6hsrxTZ2/lK3uOyL58z0VWZA+Qo pStYqS15Uk/wPRGvnyho3doVOQ/13zhNkvWNvp7nEg7jn9uqyXsuoaWHkOdK3eaF6cQF jGCaPXMnbizTQy7TgsHp6pjIeZcxTO/jG7yWt7kRa0mRte3DU98R1KyWLX9zGhHLwHvF WWYOr03jlHpB7Shs0Yrw//5a4x/PPFCZp85YOp+fDafCpkhct5M/CnQUwsrJeXzhj+zl AicA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k2si24719637pli.801.2017.11.27.18.52.41; Mon, 27 Nov 2017 18:52:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753480AbdK1Cv6 (ORCPT + 78 others); Mon, 27 Nov 2017 21:51:58 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2235 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752997AbdK1Cv5 (ORCPT ); Mon, 27 Nov 2017 21:51:57 -0500 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 4B813B27085E2; Tue, 28 Nov 2017 10:51:51 +0800 (CST) Received: from [127.0.0.1] (10.177.26.59) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.361.1; Tue, 28 Nov 2017 10:51:51 +0800 Message-ID: <5A1CCF37.2020306@huawei.com> Date: Tue, 28 Nov 2017 10:51:35 +0800 From: alex chen User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Gang He CC: , , , , , Subject: Re: [Ocfs2-devel] [PATCH 3/3] ocfs2: nowait aio support References: <1511775987-841-1-git-send-email-ghe@suse.com> <1511775987-841-4-git-send-email-ghe@suse.com> In-Reply-To: <1511775987-841-4-git-send-email-ghe@suse.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.26.59] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gang, On 2017/11/27 17:46, Gang He wrote: > Return EAGAIN if any of the following checks fail for direct I/O: > Can not get the related locks immediately, > Blocks are not allocated at the write location, it will trigger > block allocation and block IO operations. > > Signed-off-by: Gang He > --- > fs/ocfs2/dir.c | 2 +- > fs/ocfs2/dlmglue.c | 20 ++++++++++---- > fs/ocfs2/dlmglue.h | 2 +- > fs/ocfs2/file.c | 74 +++++++++++++++++++++++++++++++++++++------------- > fs/ocfs2/mmap.c | 2 +- > fs/ocfs2/ocfs2_trace.h | 10 ++++--- > 6 files changed, 79 insertions(+), 31 deletions(-) > > diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c > index febe631..ea50901 100644 > --- a/fs/ocfs2/dir.c > +++ b/fs/ocfs2/dir.c > @@ -1957,7 +1957,7 @@ int ocfs2_readdir(struct file *file, struct dir_context *ctx) > > trace_ocfs2_readdir((unsigned long long)OCFS2_I(inode)->ip_blkno); > > - error = ocfs2_inode_lock_atime(inode, file->f_path.mnt, &lock_level); > + error = ocfs2_inode_lock_atime(inode, file->f_path.mnt, &lock_level, 1); > if (lock_level && error >= 0) { > /* We release EX lock which used to update atime > * and get PR lock again to reduce contention > diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c > index 5cfbd04..feb8dbe 100644 > --- a/fs/ocfs2/dlmglue.c > +++ b/fs/ocfs2/dlmglue.c > @@ -2516,13 +2516,18 @@ int ocfs2_inode_lock_with_page(struct inode *inode, > > int ocfs2_inode_lock_atime(struct inode *inode, > struct vfsmount *vfsmnt, > - int *level) > + int *level, int wait) > { > int ret; > > - ret = ocfs2_inode_lock(inode, NULL, 0); > + if (wait) > + ret = ocfs2_inode_lock(inode, NULL, 0); > + else > + ret = ocfs2_try_inode_lock(inode, NULL, 0); > + > if (ret < 0) { > - mlog_errno(ret); > + if (ret != -EAGAIN) > + mlog_errno(ret); > return ret; > } > > @@ -2534,9 +2539,14 @@ int ocfs2_inode_lock_atime(struct inode *inode, > struct buffer_head *bh = NULL; > > ocfs2_inode_unlock(inode, 0); > - ret = ocfs2_inode_lock(inode, &bh, 1); > + if (wait) > + ret = ocfs2_inode_lock(inode, &bh, 1); > + else > + ret = ocfs2_try_inode_lock(inode, &bh, 1); > + > if (ret < 0) { > - mlog_errno(ret); > + if (ret != -EAGAIN) > + mlog_errno(ret); > return ret; > } > *level = 1; > diff --git a/fs/ocfs2/dlmglue.h b/fs/ocfs2/dlmglue.h > index 05910fc..c83dbb5 100644 > --- a/fs/ocfs2/dlmglue.h > +++ b/fs/ocfs2/dlmglue.h > @@ -123,7 +123,7 @@ void ocfs2_refcount_lock_res_init(struct ocfs2_lock_res *lockres, > void ocfs2_open_unlock(struct inode *inode); > int ocfs2_inode_lock_atime(struct inode *inode, > struct vfsmount *vfsmnt, > - int *level); > + int *level, int wait); > int ocfs2_inode_lock_full_nested(struct inode *inode, > struct buffer_head **ret_bh, > int ex, > diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c > index dc455d4..900f04e 100644 > --- a/fs/ocfs2/file.c > +++ b/fs/ocfs2/file.c > @@ -140,6 +140,8 @@ static int ocfs2_file_open(struct inode *inode, struct file *file) > spin_unlock(&oi->ip_lock); > } > > + file->f_mode |= FMODE_NOWAIT; > + > leave: > return status; > } > @@ -2132,8 +2134,7 @@ static int ocfs2_prepare_inode_for_refcount(struct inode *inode, > } > > static int ocfs2_prepare_inode_for_write(struct file *file, > - loff_t pos, > - size_t count) > + loff_t pos, size_t count, int wait) > { > int ret = 0, meta_level = 0; > struct dentry *dentry = file->f_path.dentry; > @@ -2145,10 +2146,14 @@ static int ocfs2_prepare_inode_for_write(struct file *file, > * if we need to make modifications here. > */ > for(;;) { > - ret = ocfs2_inode_lock(inode, NULL, meta_level); > + if (wait) > + ret = ocfs2_inode_lock(inode, NULL, meta_level); > + else > + ret = ocfs2_try_inode_lock(inode, NULL, meta_level); > if (ret < 0) { > meta_level = -1; > - mlog_errno(ret); > + if (ret != -EAGAIN) > + mlog_errno(ret); > goto out; > } > We will lock inode again in ocfs2_prepare_inode_for_write()->ocfs2_prepare_inode_for_refcount(). Should we add the check of 'nowait' flags? > @@ -2199,7 +2204,7 @@ static int ocfs2_prepare_inode_for_write(struct file *file, > > out_unlock: > trace_ocfs2_prepare_inode_for_write(OCFS2_I(inode)->ip_blkno, > - pos, count); > + pos, count, wait); > > if (meta_level >= 0) > ocfs2_inode_unlock(inode, meta_level); > @@ -2211,7 +2216,7 @@ static int ocfs2_prepare_inode_for_write(struct file *file, > static ssize_t ocfs2_file_write_iter(struct kiocb *iocb, > struct iov_iter *from) > { > - int direct_io, rw_level; > + int rw_level; > ssize_t written = 0; > ssize_t ret; > size_t count = iov_iter_count(from); > @@ -2223,6 +2228,8 @@ static ssize_t ocfs2_file_write_iter(struct kiocb *iocb, > void *saved_ki_complete = NULL; > int append_write = ((iocb->ki_pos + count) >= > i_size_read(inode) ? 1 : 0); > + int direct_io = iocb->ki_flags & IOCB_DIRECT ? 1 : 0; > + int nowait = iocb->ki_flags & IOCB_NOWAIT ? 1 : 0; > > trace_ocfs2_file_aio_write(inode, file, file->f_path.dentry, > (unsigned long long)OCFS2_I(inode)->ip_blkno, > @@ -2230,12 +2237,17 @@ static ssize_t ocfs2_file_write_iter(struct kiocb *iocb, > file->f_path.dentry->d_name.name, > (unsigned int)from->nr_segs); /* GRRRRR */ > > + if (!direct_io && nowait) > + return -EOPNOTSUPP; > + > if (count == 0) > return 0; > > - direct_io = iocb->ki_flags & IOCB_DIRECT ? 1 : 0; > - > - inode_lock(inode); > + if (direct_io && nowait) { > + if (!inode_trylock(inode)) > + return -EAGAIN; > + } else > + inode_lock(inode); > > /* > * Concurrent O_DIRECT writes are allowed with > @@ -2244,9 +2256,13 @@ static ssize_t ocfs2_file_write_iter(struct kiocb *iocb, > */ > rw_level = (!direct_io || full_coherency || append_write); > > - ret = ocfs2_rw_lock(inode, rw_level); > + if (direct_io && nowait) > + ret = ocfs2_try_rw_lock(inode, rw_level); > + else > + ret = ocfs2_rw_lock(inode, rw_level); > if (ret < 0) { > - mlog_errno(ret); > + if (ret != -EAGAIN) > + mlog_errno(ret); > goto out_mutex; > } > > @@ -2260,9 +2276,13 @@ static ssize_t ocfs2_file_write_iter(struct kiocb *iocb, > * other nodes to drop their caches. Buffered I/O > * already does this in write_begin(). > */ > - ret = ocfs2_inode_lock(inode, NULL, 1); > + if (nowait) > + ret = ocfs2_try_inode_lock(inode, NULL, 1); > + else > + ret = ocfs2_inode_lock(inode, NULL, 1); > if (ret < 0) { > - mlog_errno(ret); > + if (ret != -EAGAIN) > + mlog_errno(ret); > goto out; > } > > @@ -2277,9 +2297,17 @@ static ssize_t ocfs2_file_write_iter(struct kiocb *iocb, > } > count = ret; > > - ret = ocfs2_prepare_inode_for_write(file, iocb->ki_pos, count); > + if (direct_io && nowait) { > + if (!ocfs2_overwrite_io(inode, iocb->ki_pos, count, 0)) { > + ret = -EAGAIN; > + goto out; > + } > + } > + > + ret = ocfs2_prepare_inode_for_write(file, iocb->ki_pos, count, !nowait); > if (ret < 0) { > - mlog_errno(ret); > + if (ret != -EAGAIN) > + mlog_errno(ret); > goto out; > } > > @@ -2355,6 +2383,7 @@ static ssize_t ocfs2_file_read_iter(struct kiocb *iocb, > int ret = 0, rw_level = -1, lock_level = 0; > struct file *filp = iocb->ki_filp; > struct inode *inode = file_inode(filp); > + int nowait = iocb->ki_flags & IOCB_NOWAIT ? 1 : 0; > > trace_ocfs2_file_aio_read(inode, filp, filp->f_path.dentry, > (unsigned long long)OCFS2_I(inode)->ip_blkno, > @@ -2374,9 +2403,14 @@ static ssize_t ocfs2_file_read_iter(struct kiocb *iocb, > * need locks to protect pending reads from racing with truncate. > */ > if (iocb->ki_flags & IOCB_DIRECT) { > - ret = ocfs2_rw_lock(inode, 0); > + if (nowait) > + ret = ocfs2_try_rw_lock(inode, 0); > + else > + ret = ocfs2_rw_lock(inode, 0); > + > if (ret < 0) { > - mlog_errno(ret); > + if (ret != -EAGAIN) > + mlog_errno(ret); > goto bail; > } > rw_level = 0; > @@ -2393,9 +2427,11 @@ static ssize_t ocfs2_file_read_iter(struct kiocb *iocb, > * like i_size. This allows the checks down below > * generic_file_aio_read() a chance of actually working. > */ > - ret = ocfs2_inode_lock_atime(inode, filp->f_path.mnt, &lock_level); > + ret = ocfs2_inode_lock_atime(inode, filp->f_path.mnt, &lock_level, > + !nowait); Should we judge if the flags is included O_DIRECT? > if (ret < 0) { > - mlog_errno(ret); > + if (ret != -EAGAIN) > + mlog_errno(ret); > goto bail; > } > ocfs2_inode_unlock(inode, lock_level); > diff --git a/fs/ocfs2/mmap.c b/fs/ocfs2/mmap.c > index 098f5c7..fb9a20e 100644 > --- a/fs/ocfs2/mmap.c > +++ b/fs/ocfs2/mmap.c > @@ -184,7 +184,7 @@ int ocfs2_mmap(struct file *file, struct vm_area_struct *vma) > int ret = 0, lock_level = 0; > > ret = ocfs2_inode_lock_atime(file_inode(file), > - file->f_path.mnt, &lock_level); > + file->f_path.mnt, &lock_level, 1); > if (ret < 0) { > mlog_errno(ret); > goto out; > diff --git a/fs/ocfs2/ocfs2_trace.h b/fs/ocfs2/ocfs2_trace.h > index a0b5d00..e2a11aa 100644 > --- a/fs/ocfs2/ocfs2_trace.h > +++ b/fs/ocfs2/ocfs2_trace.h > @@ -1449,20 +1449,22 @@ > > TRACE_EVENT(ocfs2_prepare_inode_for_write, > TP_PROTO(unsigned long long ino, unsigned long long saved_pos, > - unsigned long count), > - TP_ARGS(ino, saved_pos, count), > + unsigned long count, int wait), > + TP_ARGS(ino, saved_pos, count, wait), > TP_STRUCT__entry( > __field(unsigned long long, ino) > __field(unsigned long long, saved_pos) > __field(unsigned long, count) > + __field(int, wait) > ), > TP_fast_assign( > __entry->ino = ino; > __entry->saved_pos = saved_pos; > __entry->count = count; > + __entry->wait = wait; > ), > - TP_printk("%llu %llu %lu", __entry->ino, > - __entry->saved_pos, __entry->count) > + TP_printk("%llu %llu %lu %d", __entry->ino, > + __entry->saved_pos, __entry->count, __entry->wait) > ); > > DEFINE_OCFS2_INT_EVENT(generic_file_aio_read_ret); > From 1585212158684407730@xxx Mon Nov 27 09:48:41 +0000 2017 X-GM-THRID: 1585212158684407730 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread