Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 4/6] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM
 support
To:     Fabio Estevam <festevam@gmail.com>
Cc:     Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <kernel@pengutronix.de>,
        Fabio Estevam <fabio.estevam@nxp.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
References: <1511785716-23492-1-git-send-email-narmstrong@baylibre.com>
 <1511785716-23492-5-git-send-email-narmstrong@baylibre.com>
 <CAOMZO5DXh1K4fnw0mCEwpXc0WFMUW1sCsjv==TUHM5vr3DqFaQ@mail.gmail.com>
From:   Neil Armstrong <narmstrong@baylibre.com>
Organization: Baylibre
Message-ID: <f4528216-b0b1-4492-8069-b3ed384fb063@baylibre.com>
Date:   Tue, 28 Nov 2017 12:16:47 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAOMZO5DXh1K4fnw0mCEwpXc0WFMUW1sCsjv==TUHM5vr3DqFaQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 27/11/2017 13:57, Fabio Estevam wrote:
> On Mon, Nov 27, 2017 at 10:28 AM, Neil Armstrong
> <narmstrong@baylibre.com> wrote:
> 
>> +&pcie {
>> +       fsl,tx-swing-full = <103>;
>> +       fsl,tx-swing-low = <103>;
>> +       reset-gpio = <&gpio4 11 GPIO_ACTIVE_HIGH>;
> 
> This can only be active high if 'reset-gpio-active-high' property is
> present, so what you
> want here is:
>   reset-gpio = <&gpio4 11 GPIO_ACTIVE_LOW>;
> 
> With this fixed:
> 
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> 

Ok,

I will post a v4 lately with this fixed.

Thanks,
Neil

From 1585224165669295706@xxx Mon Nov 27 12:59:32 +0000 2017
X-GM-THRID: 1585222352346496502
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread