Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760728AbYAKPHt (ORCPT ); Fri, 11 Jan 2008 10:07:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758444AbYAKPHl (ORCPT ); Fri, 11 Jan 2008 10:07:41 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:55017 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1756716AbYAKPHk (ORCPT ); Fri, 11 Jan 2008 10:07:40 -0500 Date: Fri, 11 Jan 2008 10:07:38 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: "Rafael J. Wysocki" cc: Greg KH , Len Brown , Ingo Molnar , ACPI Devel Maling List , pm list , LKML , Johannes Berg , Andrew Morton Subject: Re: [PATCH] PM: Acquire device locks on suspend (rev. 3) In-Reply-To: <200801110216.35446.rjw@sisk.pl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1414 Lines: 36 On Fri, 11 Jan 2008, Rafael J. Wysocki wrote: > Hi, > > The patch below is intended as a replacement for > gregkh-driver-pm-acquire-device-locks-prior-to-suspending.patch that deadlocked > suspend and hibernation on some systems.  The present patch contains some > safeguards against deadlocks in the relevant cases and a mechanism to print > warnings if a deadlock is probable. > > Greetings, > Rafael > > --- > From: Rafael J. Wysocki , Alan Stern > > This patch reorganizes the way suspend and resume notifications are > sent to drivers. The major changes are that now the PM core acquires > every device semaphore before calling the methods, and calls to > device_add() during suspends will fail, while calls to device_del() > during suspends will block. > > It also provides a way to safely remove a suspended device with the > help of the PM core, by using the device_pm_schedule_removal() callback > introduced specifically for this purpose, and updates two drivers (msr > and cpuid) that need to use it. > > Signed-off-by: Rafael J. Wysocki Signed-off-by: Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/