Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH][v4] uprobes/x86: emulate push insns for uprobe on x86
To:     Oleg Nesterov <oleg@redhat.com>
CC:     <mingo@kernel.org>, <tglx@linutronix.de>, <peterz@infradead.org>,
        <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        <netdev@vger.kernel.org>, <ast@fb.com>, <kernel-team@fb.com>
References: <20171115175928.3821714-1-yhs@fb.com>
 <20171117172526.GA10949@redhat.com>
 <47697170-3737-052e-584f-811cf4e4dbf2@fb.com>
 <20171120164145.GA2387@redhat.com>
From:   Yonghong Song <yhs@fb.com>
Message-ID: <b3b59c8a-494f-51ed-2691-c4c544e771a1@fb.com>
Date:   Mon, 20 Nov 2017 10:25:55 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171120164145.GA2387@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Received-SPF: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2017 18:25:58.8551 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 65041fcf-88fb-48c2-06a6-08d530442634
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1837
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-20_10:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/20/17 8:41 AM, Oleg Nesterov wrote:
> On 11/17, Yonghong Song wrote:
>>
>> On 11/17/17 9:25 AM, Oleg Nesterov wrote:
>>> On 11/15, Yonghong Song wrote:
>>>>
>>>> v3 -> v4:
>>>>    . Revert most of v3 change as 32bit emulation is not really working
>>>>      on x86_64 platform as among other issues, function emulate_push_stack()
>>>>      needs to account for 32bit app on 64bit platform.
>>>>      A separate effort is ongoing to address this issue.
>>>
>>> Reviewed-by: Oleg Nesterov <oleg@redhat.com>
>>>
>>>
>>>
>>> Please test your patch with the fix below, in this particular case the
>>> TIF_IA32 check should be fine. Although this is not what we really want,
>>> we should probably use user_64bit_mode(regs) which checks ->cs. But this
>>> needs more changes and doesn't solve other problems (get_unmapped_area)
>>> so I still can't decide what should we do right now...
>>
>> I tested the below change with my patch. On x86_64, both 64bit and 32bit
>> program can be uprobe emulated properly.
> 
> Good, so your patch is fine.

Thanks!

> 
>> On x86_32, however, there is a
>> compilation error like below:
> 
> Yes, yes, when I said "in this particular case" I meant x86_64 system only.
> 
> Sorry for confusion, I asked you to test this additional change just to
> ensure that we didn't miss something and your patch has no problems with
> 32bit tasks on 64bit system, except those we need to fix anyway.

Understood. I actually tried a little to see whether I could have a 
simple way to fix 32bit compilation error without using ugly "#ifdef 
CONFIG_X86_64". Maybe is_64bit_mm is a good choice. But we could defer 
this until you have a comprehensive fix for 32bit app uprobe on 64bit 
systems as there are multiple issues for this.

> 
> Oleg.
> 

From 1584604022909315407@xxx Mon Nov 20 16:42:38 +0000 2017
X-GM-THRID: 1583700940287669077
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread