Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH][v3] uprobes/x86: emulate push insns for uprobe on x86
To:     Oleg Nesterov <oleg@redhat.com>
CC:     <mingo@kernel.org>, <tglx@linutronix.de>, <peterz@infradead.org>,
        <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        <netdev@vger.kernel.org>, <ast@fb.com>, <kernel-team@fb.com>
References: <20171113221139.1516536-1-yhs@fb.com>
 <20171114155124.GB17667@redhat.com> <20171114160304.GA19323@redhat.com>
From:   Yonghong Song <yhs@fb.com>
Message-ID: <946788b4-e57b-c7c2-9ba8-3c6fe87c4af8@fb.com>
Date:   Tue, 14 Nov 2017 14:43:32 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171114160304.GA19323@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Received-SPF: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2017 22:43:36.3604 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c8799e05-7cc1-40ba-ee6a-08d52bb12569
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1831
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-14_12:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/14/17 8:03 AM, Oleg Nesterov wrote:
> On 11/14, Oleg Nesterov wrote:
>>
>>> +#ifdef CONFIG_X86_64
>>> +	if (test_thread_flag(TIF_ADDR32))
>>> +		return -ENOSYS;
>>> +#endif
>>
>> No, this doesn't look right, see my previous email. You should do this
>> check in the "if (insn->length == 2)" branch below, "push bp" should be
>> emulated correctly.
>>
>> And test_thread_flag(TIF_ADDR32) is not right too. The caller is not
>> necessarily the probed task. See is_64bit_mm(mm) in arch_uprobe_analyze_insn().
>>
>> And again... please check if uprobe_init_insn() fails or not in this case
>> (32bit task does, say, "push r8"). If it fails, your V2 should be fine.
>>
>>
>> To remind, uprobes && 32-bit is broken, let me quote my another email:
>>
>> 	The 3rd bug means that you simply can't uprobe a 32bit task on a 64bit
>> 	system, the in_compat_syscall() logic in get_unmapped_area() looks very
>> 	wrong although I need to re-check.
> 
> Yes,
> 
>> I didn't have time for this problem so far. But emulation should work, so
>> you can hopefully test your patch.
> 
> Ah, no, sizeof_long() is broken by the same reason, so you can't test it...

Right. I hacked the emulate_push_stack (original name: push_ret_address) 
with sizeof_long = 4, and 32bit binary uprobe works fine on x86_64 
platform then... But that will involve a bigger change to propogate
the is_64bit_mm() along the call graph.

> 
> OK, I'll try to do something tomorrow, then we will see what can we do
> with your patch...

Thanks for reviewing! I will wait for your further comments/direction
before next step.

> 
> But it would be nice if you can check what uprobe_init_insn() does in this
> case, see above.

As mentioned in my previous email, for 32bit application,
compiler won't generate "push %r8" as "%r8" is only available on
x86_64 platform. For 32bit app, I see "push %bp" etc which does not
have rex_prefix. They cannot be emulated right now due to 
emulate_push_stack needs change.

> 
> Oleg.
> 

From 1584082874834841603@xxx Tue Nov 14 22:39:12 +0000 2017
X-GM-THRID: 1583700940287669077
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread