Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH][v2] uprobes/x86: emulate push insns for uprobe on x86
To:     Oleg Nesterov <oleg@redhat.com>
CC:     <mingo@kernel.org>, <tglx@linutronix.de>, <peterz@infradead.org>,
        <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        <netdev@vger.kernel.org>, <ast@fb.com>, <kernel-team@fb.com>
References: <20171110172546.3185266-1-yhs@fb.com>
 <20171113125956.GA11516@redhat.com>
From:   Yonghong Song <yhs@fb.com>
Message-ID: <6fdd9773-a0d0-7598-35d4-959bb3701d1b@fb.com>
Date:   Mon, 13 Nov 2017 12:32:18 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171113125956.GA11516@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Received-SPF: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Nov 2017 20:32:22.5274 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9736b1e5-b118-45a1-f094-08d52ad5a585
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1834
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-13_11:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/13/17 4:59 AM, Oleg Nesterov wrote:
> The patch looks good to me, but I have a question because I know nothing
> about insn encoding,
> 
> On 11/10, Yonghong Song wrote:
>>
>> +static int push_setup_xol_ops(struct arch_uprobe *auprobe, struct insn *insn)
>> +{
>> +	u8 opc1 = OPCODE1(insn), reg_offset = 0;
>> +
>> +	if (opc1 < 0x50 || opc1 > 0x57)
>> +		return -ENOSYS;
>> +
>> +	if (insn->length > 2)
>> +		return -ENOSYS;
>> +	if (insn->length == 2) {
>> +		/* only support rex_prefix 0x41 (x64 only) */
>> +#ifdef CONFIG_X86_64
>> +		if (insn->rex_prefix.nbytes != 1 ||
>> +		    insn->rex_prefix.bytes[0] != 0x41)
>> +			return -ENOSYS;
>> +
>> +		auprobe->push.ilen = 2;
> 
> and the "else" branch does
> 
> 		auprobe->push.ilen = 1;
> 
> you could add
> 		auprobe->push.ilen = insn->length;
> 
> at the end of push_setup_xol_ops() instead, but this is minor/cosmetic,

Will make this change in the next revision.

> 
> 
>> +		switch (opc1) {
>> +		case 0x50:
>> +			reg_offset = offsetof(struct pt_regs, r8);
>> +			break;
>> +		case 0x51:
>> +			reg_offset = offsetof(struct pt_regs, r9);
>> +			break;
>> +		case 0x52:
>> +			reg_offset = offsetof(struct pt_regs, r10);
>> +			break;
>> +		case 0x53:
>> +			reg_offset = offsetof(struct pt_regs, r11);
>> +			break;
>> +		case 0x54:
>> +			reg_offset = offsetof(struct pt_regs, r12);
>> +			break;
>> +		case 0x55:
>> +			reg_offset = offsetof(struct pt_regs, r13);
>> +			break;
>> +		case 0x56:
>> +			reg_offset = offsetof(struct pt_regs, r14);
>> +			break;
>> +		case 0x57:
>> +			reg_offset = offsetof(struct pt_regs, r15);
>> +			break;
>> +		}
>> +#else
>> +		return -ENOSYS;
>> +#endif
> 
> OK, but shouldn't we also return ENOSYS if CONFIG_X86_64=y but the probed task is 32bit?

Just tested with a 32bit app on x86 box and segfaults. Yes, we would 
need to return ENOSYS if the app is 32bit on 64bit system. I may not
be worthwhile to emulate this uncommon case.

I will use mmap_is_ia32 or a variant to test whether the app is
32bit or not. Please let me know whether this is correct approach or not.

> 
> Or in this case uprobe_init_insn(x86_64 => false) should fail and push_setup_xol_ops()
> won't be called?
> 
> Oleg.
> 

From 1583957636462398446@xxx Mon Nov 13 13:28:36 +0000 2017
X-GM-THRID: 1583700940287669077
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread