Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Sven Joachim <svenjoac@gmx.de>
To:     Josh Poimboeuf <jpoimboe@redhat.com>
Cc:     Mikulas Patocka <mpatocka@redhat.com>,
        Andy Lutomirski <luto@kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        Brian Gerst <brgerst@gmail.com>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Jiri Slaby <jslaby@suse.cz>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
        Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] objtool: fix build of 64-bit kernel with 32-bit userspace
References: <alpine.LRH.2.02.1711061812460.18820@file01.intranet.prod.int.rdu2.redhat.com>
        <20171107175539.zkbzaapmok2b7hbb@treble>
Date:   Mon, 27 Nov 2017 18:32:48 +0100
In-Reply-To: <20171107175539.zkbzaapmok2b7hbb@treble> (Josh Poimboeuf's
        message of "Tue, 7 Nov 2017 11:55:39 -0600")
Message-ID: <87r2sjzkxr.fsf@turtle.gmx.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2017-11-07 11:55 -0600, Josh Poimboeuf wrote:

> [ Adding Ingo to cc because I believe it was his suggestion to hide the
>   guess unwinder behind CONFIG_EXPERT. ]
>
> On Mon, Nov 06, 2017 at 06:27:53PM -0500, Mikulas Patocka wrote:
>> This patch fixes building of 64-bit kernel on 32-bit userspace (I tested 
>> it on RHEL-6-i686 and Debian-Sid-x32).
>
> Thanks, I'll review the patch.

Any news on that?  After upgrading to 4.15-rc1 and running
"make oldconfig" I found out that the kernel would no longer build
unless I selected CONFIG_UNWINDER_FRAME_POINTER=y.

,----
| $ uname -m
| x86_64
| $ dpkg --print-architecture 
| i386
`----

>> There are still some more bugs - when building 64-bit kernel on 32-bit
>> Debian 7 distribution, objtool corrupts object files so that the linker
>> doesn't recognize them (ld doesn't recognize the format of the file at all
>> and gold prints a lot of errors).
>
> Hm, we should figure out what's going on there...
>
>> Another problem - when building 32-bit kernel, why do you force frame
>> pointers on and why did you hide CONFIG_GUESS_UNWINDER behind
>> CONFIG_EXPERT? Frame pointers increase code size and register pressure,
>> most users don't need precise stacktraces, so CONFIG_GUESS_UNWINDER should
>> be default for non-expert users just like it was before.
>> 
>> Is there some technical reason why do you want to avoid 
>> CONFIG_GUESS_UNWINDER?
>
> The technical reason for avoiding the guess unwinder is that it's
> sketchy: it gives false positive results.  Not only for oopses, but for
> all the other users of the unwinder: /proc/<pid>/stack, perf, lockdep,
> etc.  So it's a correctness issue.
>
> I agree with you that the frame pointer unwinder has drawbacks, but if
> somebody cares about those drawbacks, I would consider that person an
> "expert" ;-)

Cheers,
       Sven

From 1583484604288522117@xxx Wed Nov 08 08:09:57 +0000 2017
X-GM-THRID: 1583371660305144659
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread