Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5A1337DF.2060404@bfs.de>
Date:   Mon, 20 Nov 2017 21:15:27 +0100
From:   walter harms <wharms@bfs.de>
Reply-To: wharms@bfs.de
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11
MIME-Version: 1.0
To:     Colin King <colin.king@canonical.com>
CC:     Johan Hovold <johan@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: iuu_phoenix: remove redundant assignment
 of DIV to itself
References: <20171120174015.7191-1-colin.king@canonical.com>
In-Reply-To: <20171120174015.7191-1-colin.king@canonical.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Am 20.11.2017 18:40, schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The assignment of DIV to itself is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/usb/serial/iuu_phoenix.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/serial/iuu_phoenix.c
> index 397a8012ffa3..62c91e360baf 100644
> --- a/drivers/usb/serial/iuu_phoenix.c
> +++ b/drivers/usb/serial/iuu_phoenix.c
> @@ -472,7 +472,6 @@ static int iuu_clk(struct usb_serial_port *port, int dwFrq)
>  				}
>  	}
>  	P2 = ((P - PO) / 2) - 4;
> -	DIV = DIV;
>  	PUMP = 0x04;
>  	PBmsb = (P2 >> 8 & 0x03);
>  	PBlsb = P2 & 0xFF;

These all all-upper-case stuff makes me a bit nervous. Normally this
is reserved for #define ( I assume that the programmer refers to
the original documentation) a point to change ?

btw: i noticed  int frq = (int)dwFrq;
since dwFrq is already an in, the cast is useless.

just ym 2 cents,

re,
 wh


From 1584607703111798996@xxx Mon Nov 20 17:41:08 +0000 2017
X-GM-THRID: 1584607703111798996
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread