Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Wang, Zhi A" <zhi.a.wang@intel.com>
To:     David Binderman <dcb314@hotmail.com>,
        "zhenyuw@linux.intel.com" <zhenyuw@linux.intel.com>,
        "jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>,
        "joonas.lahtinen@linux.intel.com" <joonas.lahtinen@linux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
        "airlied@linux.ie" <airlied@linux.ie>,
        "intel-gvt-dev@lists.freedesktop.org" 
        <intel-gvt-dev@lists.freedesktop.org>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: linux-4.15-rc1/drivers/gpu/drm/i915/gvt/cmd_parser.c:1640: poor
 error checking ?
Thread-Topic: linux-4.15-rc1/drivers/gpu/drm/i915/gvt/cmd_parser.c:1640:
 poor error checking ?
Thread-Index: AQHTZ3aMgU2Sz/z7e0e0vaKrKH6Ap6MoIuYA
Date:   Mon, 27 Nov 2017 12:14:19 +0000
Message-ID: <F3B0350DF4CB6849A642218320DE483D7D683A8B@SHSMSX104.ccr.corp.intel.com>
References: <HE1PR0802MB2331E2A22777E67B3B5296429C250@HE1PR0802MB2331.eurprd08.prod.outlook.com>
In-Reply-To: <HE1PR0802MB2331E2A22777E67B3B5296429C250@HE1PR0802MB2331.eurprd08.prod.outlook.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thanks for the email. It has been refined recently, the code can be found here:

https://cgit.freedesktop.org/drm-intel/tree/drivers/gpu/drm/i915/gvt/cmd_parser.c

Thanks for the notification, again. :)

-----Original Message-----
From: David Binderman [mailto:dcb314@hotmail.com] 
Sent: Monday, November 27, 2017 1:59 PM
To: zhenyuw@linux.intel.com; Wang, Zhi A <zhi.a.wang@intel.com>; jani.nikula@linux.intel.com; joonas.lahtinen@linux.intel.com; Vivi, Rodrigo <rodrigo.vivi@intel.com>; airlied@linux.ie; intel-gvt-dev@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org
Subject: linux-4.15-rc1/drivers/gpu/drm/i915/gvt/cmd_parser.c:1640: poor error checking ?


Hello there,

linux-4.15-rc1/drivers/gpu/drm/i915/gvt/cmd_parser.c:1640]: (style) Checking if unsigned variable 'bb_size' is less than zero.

Source code is

    /* get the size of the batch buffer */
    bb_size = find_bb_size(s);
    if (bb_size < 0)
        return -EINVAL;

but

static int find_bb_size(struct parser_exec_state *s)

so the code isn't properly checking the return value. Suggest code rework.

Regards

David Binderman

From 1585323110598494749@xxx Tue Nov 28 15:12:13 +0000 2017
X-GM-THRID: 1585323110598494749
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread