Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20171117142038.GE17880@kroah.com>
References: <20171117142038.GE17880@kroah.com>
From:   Philippe Ombredanne <pombredanne@nexb.com>
Date:   Fri, 17 Nov 2017 15:53:49 +0100
Message-ID: <CAOFm3uGa01Zkpc7sDeosB0HSKcqb4gjiQK32wF8aq7VcNAEkZQ@mail.gmail.com>
Subject: Re: [PATCH] ntb: remove unneeded DRIVER_LICENSE #defines
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Jon Mason <jdmason@kudzu.us>, Dave Jiang <dave.jiang@intel.com>,
        Allen Hubbe <Allen.Hubbe@emc.com>,
        Gary R Hook <gary.hook@amd.com>,
        Serge Semin <fancer.lancer@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>, linux-ntb@googlegroups.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Nov 17, 2017 at 3:20 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> There is no need to #define the license of the driver, just put it in
> the MODULE_LICENSE() line directly as a text string.
>
> This allows tools that check that the module license matches the source
> code license to work properly, as there is no need to unwind the
> unneeded dereference, especially when the string is defined just a few
> lines above the usage of it.
>
> Cc: Jon Mason <jdmason@kudzu.us>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Allen Hubbe <Allen.Hubbe@emc.com>
> Cc: Gary R Hook <gary.hook@amd.com>
> Cc: Serge Semin <fancer.lancer@gmail.com>
> Reported-by: Philippe Ombredanne <pombredanne@nexb.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
-- 
Cordially
Philippe Ombredanne

From 1585216261241488702@xxx Mon Nov 27 10:53:54 +0000 2017
X-GM-THRID: 1585216261241488702
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread